Well, you shouldn't wrap your code in a canvas if it is going into the LFC. So the LFC compiler would treat it more like a library file (does it need to be in a <library> just to make XML happy, I think so).

I think we just figured out what fun new feature you should work on!

On 2009-09-24, at 15:21, Henry Minsky wrote:

Ooh, that's a nice idea ... it would want to omit any cavas and application
init stuff.
I think that's what the flex compiler does, you can pass it .mxml or .as
files, although
I'm not sure if you can pass it both at the same time.



On Thu, Sep 24, 2009 at 2:58 PM, P T Withington <[email protected]>wrote:

Coming late to the review party:

It's interesting (and apropos of our discussion this morning) that you found it easier to write contextmenu in LZX than in script. Maybe we should make this easier to do? Rather than you having to provide a recipe in contextmenu.lzx for how to build contextmenu.js, could we extend the LFC
compiler to just do the right thing if you include an LZX file?


On 2009-09-21, at 23:48, Max Carlson wrote:

Change 20090921-maxcarlson-h by [email protected] on 2009-09-21
19:00:12 PDT
 in /Users/maxcarlson/openlaszlo/trunk-clean
 for http://svn.openlaszlo.org/openlaszlo/trunk

Summary: UPDATED: Update look of context menu

Bugs Fixed: LPP-8286 - DHTML: Improve look of context menu

Technical Reviewer:ptw
QA Reviewer: hminsky

Details: Updated to fix layout of items and correct the issue Henry
was seeing.

LzContextMenuKernel - Use lz.lzcontextmenu class to handle display of
context menu - see contextmenu.js/lzx.

LzSprite - Remove unused styles

LzMouseKernel - contextmenu.js now handles hiding when the mouse goes
down outside itself.

contextmenu.js - compiled version of contextmenu.lzx with canvas
constructor/preamble and canvas.initDone() removed.

contextmenu.lzx - source lzx for contextmenu.js

LaszloLibrary - Add contextmenu.js include for DHTML.  Must be
declared late because the context menu relies on the LFC

Tests: context menus work as before, but they're prettier now!  Also
see test/contextmenu/api.lzx?lzr=dhtml

Files:
M       WEB-INF/lps/lfc/kernel/dhtml/LzContextMenuKernel.lzs
M       WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
M       WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js
A       WEB-INF/lps/lfc/contextmenu.js
A       WEB-INF/lps/lfc/contextmenu.lzx
M       WEB-INF/lps/lfc/LaszloLibrary.lzs

Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20090921-maxcarlson-h.tar
_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews





--
Henry Minsky
Software Architect
[email protected]

Reply via email to