I'm pretty sure those errors are from the Google page assuming it wasn't
loaded in an iframe.
On 4/8/10 6:39 AM, Henry Minsky wrote:
Approved. The two test cases (lpp-8884 and lpp8160) work in IE7.
There is an error that occurs in IE7 for the test case from LPP-8160,
I've attached the screen shot
from Windows. I don't think this is related to this bug fix, but
something needs to check for visibility
before applying focus or something.
test case from LPP-8160:
<canvas>
<view width="50" height="50" bgcolor="0x0000FF">
<handler name="onmouseover">
Debug.write('view 1 onmouseover');
</handler>
</view>
<html src="http://www.google.com"; width="500" height="500" y="100">
<handler name="onmouseover">
Debug.write('html onmouseover');
</handler>
</html>
<view width="50" height="50" y="150" x="150" bgcolor="0x0000FF">
<handler name="onmouseover">
Debug.write('view 2 onmouseover');
</handler>
<handler name="oninit">
this.bringToFront();
</handler>
</view>
</canvas>
On Thu, Apr 8, 2010 at 8:05 AM, P T Withington <[email protected]
<mailto:[email protected]>> wrote:
Nit:
1) If we don't need this code any more, lets actually remove it.
Jira and svn leave enough of a paper trail for us to recover it.
Question:
1) What changed that we no longer need this? I take it that the
original test case in LPP-8160 still passes?
Approved technically. But I somehow got magically upgraded to IE 8,
so I'm relying on the QA reviewer to actually test the fix.
On 2010-04-08, at 01:37, Max Carlson wrote:
> Change 20100407-maxcarlson-E by [email protected] on
2010-04-07 22:34:42 PDT
> in /Users/maxcarlson/openlaszlo/trunk-clean
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Fix <html/> mouse activation when an inputtext is
focused in IE DHTML
>
> Bugs Fixed: LPP-8884 - IE DHTML: focusing on inputext lose mouse
events on iframe
>
> Technical Reviewer: ptw
> QA Reviewer: hminsky
>
> Details: Back out fix for LPP-8160. This is more voodoo that we
don't appear to need anymore (whew!)
>
> Tests: See LPP-8884 and LPP-8160
>
> Files:
> M lps/includes/source/iframemanager.js
>
> Changeset:
http://svn.openlaszlo.org/openlaszlo/patches/20100407-maxcarlson-E.tar
>
--
Henry Minsky
Software Architect
[email protected] <mailto:[email protected]>
--
Regards,
Max Carlson
OpenLaszlo.org
