comment on xmlEscape needs to have entities escaped :-)

Index: LzMessage.lzs
===================================================================
--- LzMessage.lzs    (revision 16862)
+++ LzMessage.lzs    (working copy)
@@ -122,7 +122,7 @@
    * @devnote [2010-06-21 ptw] While XML defines 5 non-numeric
    * entities
    * (
http://en.wikipedia.org/wiki/List_of_XML_and_HTML_character_entity_references#Predefined_entities_in_XML
)
-   * only `<` and `&` function as syntactic markers, so for the
+   * only `&lt;` and `&amp;` function as syntactic markers, so for the
    * purposes of this method, only they need to be escaped to prevent
    * them being interpreted as markup.
    */

If you approve, I  can check in this change



 [java] [Fatal Error] :4:9: The content of elements must consist of
well-formed character data or markup.
     [java] Jul 2, 2010 11:12:04 AM org.openlaszlo.js2doc.JS2DocUtils
setXMLContent
     [java] WARNING: Could not parse comment '<fragment>[2010-06-21 ptw]
While XML defines 5 non-numeric
     [java]  entities
     [java]  (
http://en.wikipedia.org/wiki/List_of_XML_and_HTML_character_entity_references#Predefined_entities_in_XML
)
     [java]  only `<` and `&` function as syntactic markers, so for the
     [java]  purposes of this method, only they need to be escaped to
prevent
     [java]  them being interpreted as markup.</fragment>'
     [java] org.xml.sax.SAXParseException: The content of elements must
consist of well-formed character data or markup.
     [java]     at org.apache.xerces.parsers.DOMParser.parse(Unknown Source)
     [java]     at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown
Source)
     [java]     at
org.openlaszlo.js2doc.JS2DocUtils.setXMLContent(JS2DocUtils.java:118)
     [java]     at
org.openlaszlo.js2doc.Comment.appendAsXML(Comment.java:286)
     [java]     at
org.openlaszlo.js2doc.PropertyReference.setPropertyMetadata(PropertyReference.java:295)
     [java]     at
org.openlaszlo.js2doc.PropertyReference.redefineProperty(PropertyReference.java:105)
     [java]     at
org.openlaszlo.js2doc.JS2Doc$Visitor.visitMethodDeclaration(JS2Doc.java:513)
     [java]     at
org.openlaszlo.js2doc.JS2Doc$Visitor.visitModifiedDefinition(JS2Doc.java:534)
     [java]     at
org.openlaszlo.js2doc.JS2Doc$Visitor.visitClassStatement(JS2Doc.java:428)
     [java]     at
org.openlaszlo.js2doc.JS2Doc$Visitor.visitClassDeclaration(JS2Doc.java:399)
     [java]     at
org.openlaszlo.js2doc.JS2Doc$Visitor.visitModifiedDefinition(JS2Doc.java:536)
     [java]     at
org.openlaszlo.js2doc.JS2Doc$Visitor.visitToplevelStatement(JS2Doc.java:108)
     [java]     at
org.openlaszlo.js2doc.JS2Doc$Visitor.visitToplevelStatement(JS2Doc.java:91)
     [java]     at
org.openlaszlo.js2doc.JS2Doc$Visitor.visitUnit(JS2Doc.java:156)
     [java]     at
org.openlaszlo.js2doc.JS2Doc$Visitor.visitIncludeDirective(JS2Doc.java:586)
     [java]     at
org.openlaszlo.js2doc.JS2Doc$Visitor.visitToplevelStatement(JS2Doc.java:104)
     [java]     at
org.openlaszlo.js2doc.JS2Doc$Visitor.visitToplevelStatement(JS2Doc.java:91)
     [java]     at
org.openlaszlo.js2doc.JS2Doc$Visitor.visitUnit(JS2Doc.java:156)
     [java]     at
org.openlaszlo.js2doc.JS2Doc$Visitor.visitIncludeDirective(JS2Doc.java:586)
     [java]     at
org.openlaszlo.js2doc.JS2Doc$Visitor.visitToplevelStatement(JS2Doc.java:104)
     [java]     at
org.openlaszlo.js2doc.JS2Doc$Visitor.visitToplevelStatement(JS2Doc.java:91)
     [java]     at
org.openlaszlo.js2doc.JS2Doc$Visitor.visitUnit(JS2Doc.java:156)
     [java]     at org.openlaszlo.js2doc.JS2Doc.toXML(JS2Doc.java:879)
     [java]     at org.openlaszlo.js2doc.Main.process(Main.java:213)
     [java]     at org.openlaszlo.js2doc.Main.js2doc(Main.java:183)
     [java]     at org.openlaszlo.js2doc.Main.main(Main.java:57)
     [java] Jul 2, 2010 11:12:04 AM org.openlaszlo.js2doc.JS2Doc$Visitor
visitToplevelStatement
     [java] WARNING: Unhandled toplevel statement type
org.openlaszlo.sc.parser.ASTIdentifier
     [java] Jul 2, 2010 11:12:04 AM org.openlaszlo.js2doc.JS2Doc$Visitor
visitToplevelStatement


-- 
Henry Minsky
Software Architect
[email protected]

Reply via email to