Yes, this will be necessary. The JavaCC grammar used in the non-trunk
branches is incompatible with JavaCC 5 due to some JavaCC internal bugs. :-(
I'm going to commit the changes for trunk now.
- André
On 2/4/2011 2:52 AM, Fred Ellenberger wrote:
André ,
I have executed steps 1-4 below on linux-builder, windows-builder, and
tiger-builder.
Since we have a unified build process in place (shared build scripts)
for all OL branches currently, I believe that I will have to implement
some sort of script change to support building non-trunk branches with
the older JavaCC. Do correct me if I am wrong, else I will work on that
in the coming days.
Thanks.
-Fred
On 2/3/2011 4:10 PM, André Bargull wrote:
JavaCC will be updated to version 5 in an upcoming change. Using
JavaCC 5 also requires to compile the Java sources against Java 5 due
to the use of Java 5 features in the generated Java classes, namely
annotations and generics. JavaCC 5 and updated build scripts already
have been committed to the tools and vendor projects. The build
instructions on the wiki [1, 2] have been updated as well.
As soon as the change has been committed to trunk, it's no longer
possible to use JavaCC 2.1 to build trunk and JavaCC 5 needs to be used.
What you'll need to do is:
1) svn update http://svn.openlaszlo.org/vendor
2) unzip the javacc-5.0.zip file from $LZ_INSTALLS_ROOT to
$LZ_VENDOR_ROOT (or wherever you'd like to install JavaCC 5)
3) svn update http://svn.openlaszlo.org/tools/trunk to get the latest
build scripts
4) update the environment variable JAVACC_HOME accordingly to the new
destination (this is already done in tools/env/setup-lps.sh)
5) svn update http://svn.openlaszlo.org/openlaszlo/trunk
6) start a new build of trunk to test everything is still working :-)
Note:
- Updating to JavaCC 5 and using it with current trunk (r18393) will
fail the build.
- Not updating to JavaCC 5 after I've committed the change will fail
the build, too.
I'll commit the change [3] after I've got the OK from Tucker and Fred
that everything is set on the build machines, that means steps 1-4
from above have been applied.
Thanks,
André
[1] http://wiki.openlaszlo.org/SubversionBuildInstructions#Install_JavaCC
[2]
http://wiki.openlaszlo.org/NativeWindows7SubversionBuildInstructions#Install_javacc
[3]
http://openlaszlo.org/pipermail/laszlo-reviews/2011-February/003586.html
