Approved! On 2009-06-22, at 16:20EDT, Henry Minsky wrote:
> Change 20090622-hqm-7 by [email protected] on 2009-06-22 16:16:32 EDT > in /Users/hqm/openlaszlo/trunk6/WEB-INF/lps/lfc > for http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc > > Summary: fix for dhtml keyboard bug > > New Features: > > Bugs Fixed: LPP-8285, LPP-8279 > > Technical Reviewer: ptw > QA Reviewer: max > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Details: > > The code in LzKeyboardKernel.js which handles the OSX 'meta' key was > messing up > the Windows/IE7 key down map. > > + added a 'hasmetakey' quirk, to enable that code, and removed the > 'detectstuckkeys' quirk. > > Tests: > > Test case below: press control, shift, or any alphanumeric key, and > watch that the > status shows the key is pressed during the whole time you hold it > down. > > <canvas> > <simplelayout spacing="4"/> > <text id="ctrlkey" width="300"/> > <text id="shiftkey" width="300"/> > <text id="akey" width="300"/> > <text id="timer" width="300"/> > > <handler reference="lz.Idle" name="onidle"> > ctrlkey.setAttribute('text',"isCtrlDown: "+ > lz.Keys.isKeyDown( "control" )); > shiftkey.setAttribute('text', "isShiftDown: "+ > lz.Keys.isKeyDown( "shift" )); > akey.setAttribute('text', "a key: "+ lz.Keys.isKeyDown( "a" )); > timer.setAttribute('text', new Date().getTime()); > </handler> > > </canvas> > > > Files: > M kernel/dhtml/LzKeyboardKernel.js > M kernel/dhtml/LzSprite.js > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090622-hqm-7.tar _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
