Not approved. When Max submitted his change r13009 for review, I asked him:
> 5. Isn't making resize default to false for input text an API change? So maybe he took that out, in response to my comment? My question still remains. This is going to fix Amazon, but it will be an API change that will potentially break other applications that were depending on the existing default. This makes me think the regression is not that resize used to default to false and Max's change made it default to true and you are just putting that back. The regression must be something else. The only change that Max made that would affect all platforms is to call _updateSize when any of the attributes of a text change (e.g., font, etc.). So I think this is where the regression lies: _updateSize is being called on an input text, which has no text, so it gets resized to 0 width. I think we need to ask: 1) Should input text resize default to true? If so, what does that mean? (Since, as we see, you can't enter anything if it is initially empty). 2) Should we change the default, and if so, does it need API review? 3) Maybe it should be left as is, but we need to have a concept of minimum size? 4) Or maybe you should not resize an input field if it is empty? I could be convinced that your change is the right thing, but I'm not yet. On 2009-07-10, at 00:11EDT, Henry Minsky wrote: > This restores the conventional behavior, input text defaults to > width 100 unless otherwise specified. At some point maybe we > should do something less arbitrary, like size it to the parent's > width or something. > > > Change 20090710-hqm-H by [email protected] on 2009-07-10 00:06:33 EDT > in /Users/hqm/openlaszlo/trunk6 > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: default 'resize' to false for input text > > New Features: > > Bugs Fixed: LPP-8310 > > Technical Reviewer: max > QA Reviewer: ptw > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Details: > > + The 'resize' property of LzInputText was defaulting to 'true', so > that an <inputtext> > with no initial text value would resize to zero width when it was > constructed. > > > + Added code to LzInputText.construct() to default resize to false. > > Tests: > > Amazon search field can be typed into > > Files: > M WEB-INF/lps/lfc/views/LzInputText.lzs > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20090710-hqm-H.tar _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
