I approve this change. I filed a separate bug if the set url while playing regression (which, I agree, is likely unrelated to this change): http://jira.openlaszlo.org/jira/browse/LPP-8333
On Jul 14, 2009, at 12:35 PM, Max Carlson wrote: > I see the same thing after a clean build... As you said, pausing > and playing the video starts it again. > > I can't see how this change would cause this regression, because it > only changes the behavior at init time. In fact, I see the > regression in test-stream-video-sep.lzx with and without my change. > > Can you file another bug, and approve this one if you see fit? > Thanks! > > Sarah Allen wrote: >> the pausing of video on first frame works, but now set url seems to >> be broken in this test: test-stream-video-sep.lzx? >> debug=true&lzr=swf8 >> On Jul 14, 2009, at 11:34 AM, Max Carlson wrote: >>> Change 20090714-maxcarlson-Y by [email protected] on >>> 2009-07-14 11:29:42 PDT >>> in /Users/maxcarlson/openlaszlo/trunk-clean >>> for http://svn.openlaszlo.org/openlaszlo/trunk >>> >>> Summary: Fix videoviews for paused/single frame videos >>> >>> Bugs Fixed: LPP-8293 - test-video.lzx: sound plays but no video >>> appears (swf8 & swf9) >>> >>> Technical Reviewer: [email protected] >>> QA Reviewer: [email protected] >>> >>> Details: Move URL setting before playback setup to ensure the >>> stream isn't reset by the call to mediastream._resetStream() in >>> mediastream._updateUrl(). >>> >>> Tests: test/video/test-video.lzx shows paused video on the left. >>> test/video/test-stream-video-sep.lzx pauses the video when 'set >>> URL' buttons are clicked, and clicking 'play' causes the correct >>> video to play. >>> >>> Files: >>> M lps/components/extensions/av/videoview.lzx >>> >>> Changeset: >>> http://svn.openlaszlo.org/openlaszlo/patches/20090714-maxcarlson-Y.tar > > -- > Regards, > Max Carlson > OpenLaszlo.org http://www.ultrasaurus.com _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
