Thw reason I did it that way is so the initial state is correct, e.g. Native
context menus are shown. Otherwise te code would be more complicated because
the state in the hidenativecontextmenus hash would have to for each iframe
would have to be initialized - potentially conflicting with a user's setting.
-----Original Message-----
From: Henry Minsky <[email protected]>
Sent: Wednesday, July 22, 2009 1:51 PM
To: Max Carlson <[email protected]>
Cc: [email protected]; [email protected]
Subject: Re: For Review: Change 20090722-maxcarlson-N Summary: Allow native
context menus to be shown for the html tag
It works for me, approved.
But one style issue, it
seems a little confusing to have "shownativecontextmenu" flag which then
sets a "hidenativecontextmenu" flag in the lz.embed. I prefer flags
to have a 'positive' sense, it's easier to read code with positive rather than
negative assertions, so would prefer "shownativecontextmenu".
On Wed, Jul 22, 2009 at 3:22 PM, Max Carlson <[email protected]> wrote:
Change 20090722-maxcarlson-N by [email protected] on 2009-07-22 10:21:10 PDT
in /Users/maxcarlson/openlaszlo/trunk-clean
for http://svn.openlaszlo.org/openlaszlo/trunk
Summary: Allow native context menus to be shown for the html tag
Bugs Fixed: LPP-8298 - In DHTML the html component should show the iframes
right click menu, not the lzx right click menu
Technical Reviewer: hminsky
QA Reviewer: mdemmon
Details: lps/components/extensions/html.lzx - Add shownativecontextmenu
attribute and setter, clarify documentation for mouseevents setter.
iframemanager.js - Add setShowNativeContextMenu() to receive and store state
from the html component. Always show native context menus if set to true for a
given iframe. Don't forward oncontextmenu events to Flash runtimes.
examples/extensions/html.lzx - Add button that toggles native context menus
on/off to test the functionality.
Tests: examples/extensions/html.lzx - Clicking 'Toggle native context menus'
works in dhtml. Clicking the 'Toggle native context menus' button in swf warns
if the debu
[The entire original message is not included]
_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
