I found that disabling the dom_breaks_focus quirk partially fixes clicking into text fields for LPP-7786 in Firefox. There are still issues when tabbing - I think you need to take focus events into consideration. It's not just mousing over that should activate the field - tabbing should also. When I tab into a field it takes several clicks to be able to activate the insertion cursor.
IE doesn't look too bad at all. There may be some small bugs but the component sampler works pretty well. Overall this is a big step towards simplifying the code! P T Withington wrote: > This change regresses LPP-7786, but maybe that fix can be backed out > since we are no longer re-parenting the inputtext element? > > On 2009-07-23, at 11:23EDT, P T Withington wrote: > >> [I think this is pretty close to working!] >> >> Change 20090722-ptw-k by [email protected] on 2009-07-22 >> 17:43:39 EDT >> in /Users/ptw/OpenLaszlo/trunk >> for http://svn.openlaszlo.org/openlaszlo/trunk >> >> Summary: Don't re-parent input text to click tree >> >> Bugs Fixed: LPP-5447 DHTML: inputtext and clickable >> >> Technical Reviewer: max (pending) >> QA Reviewer: [email protected] (pending) >> >> Details: >> This is just a first pass. It doesn't reparent the input text >> sprite into the click tree, and it turns off the click tree when >> you mouse over in input element. The test case works in Safari, >> and Firefox. I have not tested IE. >> >> LzSprite: Move the canvas hiding from the CSS class style to the >> canvas >> div, so removing it just removes the div style (and the div >> reverts to the class style default). Similarly for controlling >> visibility on all divs. Correct fencepost error in __isMouseOver. >> >> LzInputTextSprite: Add documentation from Max. Fix init clauses >> that were causing the schema-generator to warn. Remove >> reparenting code, replace with hiding/showing the click tree. Now >> we can just turn the whole click tree on and off, since we are not >> reparenting, which should be much more efficient. Only re-enable >> click tree when we _actually_ leave the bounding box of the input >> element. >> >> Tests: >> Test case from LPP-8334 >> >> Files: >> M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js >> M WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js >> >> >> Changeset: >> http://svn.openlaszlo.org/openlaszlo/patches/20090722-ptw-k.tar > -- Regards, Max Carlson OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
