I'll update this change once I get 20090728-maxcarlson-L in... P T Withington wrote: > I'm confused then, because it seems like a lot of the changes are > duplicated in both of these review requests. > > Maybe you should send a single review request with the combined change, > rather than this request for a change you know you don't want? > > On 2009-07-29, at 13:19EDT, Max Carlson wrote: > >> No, it doesn't. It should be applied, and the changes to >> focusoverlay.lzx backed out - they're no longer needed with change >> 20090728-maxcarlson-L applied... >> >> P T Withington wrote: >>> Does Change 20090728-maxcarlson-L supercede this? >>> On 2009-07-27, at 19:25EDT, Max Carlson wrote: >>>> Change 20090727-maxcarlson-U by [email protected] on 2009-07-27 >>>> 16:21:22 PDT >>>> in /Users/maxcarlson/openlaszlo/trunk-clean >>>> for http://svn.openlaszlo.org/openlaszlo/trunk >>>> >>>> >>>> Summary: UPDATED: Don't re-parent input text to click tree >>>> >>>> Bugs Fixed: LPP-5447 DHTML: inputtext and clickable >>>> >>>> Technical Reviewer: ptw (pending) >>>> QA Reviewer: [email protected] (pending) >>>> >>>> Details: >>>> This is based on Tucker's change >>>> (http://svn.openlaszlo.org/openlaszlo/patches/20090722-ptw-k.tar >>>> ). I turned off the dom_breaks_focus quirk for firefox, cleaned up >>>> LzMouseKernel to not attempt to re-focus inputtexts when showing the >>>> click tree again. I also changed focusoverlay to allow clicks through >>>> to an inputtext when the focus animation is happening. >>>> >>>> This is just a first pass. It doesn't reparent the input text >>>> sprite into the click tree, and it turns off the click tree when >>>> you mouse over in input element. The test case works in Safari, >>>> and Firefox. I have not tested IE. >>>> >>>> LzSprite: Move the canvas hiding from the CSS class style to the >>>> canvas >>>> div, so removing it just removes the div style (and the div >>>> reverts to the class style default). Similarly for controlling >>>> visibility on all divs. Correct fencepost error in __isMouseOver. >>>> >>>> LzInputTextSprite: Add documentation from Max. Fix init clauses >>>> that were causing the schema-generator to warn. Remove >>>> reparenting code, replace with hiding/showing the click tree. Now >>>> we can just turn the whole click tree on and off, since we are not >>>> reparenting, which should be much more efficient. Only re-enable >>>> click tree when we _actually_ leave the bounding box of the input >>>> element. >>>> >>>> Tests: >>>> Test case from LPP-8334 >>>> >>>> Files: >>>> M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js >>>> M WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js >>>> M WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js >>>> M lps/components/lz/focusoverlay.lzx >>>> >>>> Changeset: >>>> http://svn.openlaszlo.org/openlaszlo/patches/20090727-maxcarlson-U.tar >>>> _______________________________________________ >>>> Laszlo-reviews mailing list >>>> [email protected] >>>> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews >> >> -- >> Regards, >> Max Carlson >> OpenLaszlo.org >
-- Regards, Max Carlson OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
