I like the simplifications! The fewer quirks the better. One thing I worry about is that IE's mouseenter/mouseleave are not quite equivalent to mouseover/mouseout. In particular, you can get mouseout events when the mouse is still 'in' a div (if the mouse enters a child div or an overlying div). This is why in the mouseout handler I have to ask __isMouseOver. Interestingly, this is one case where ppk (quirksmode.org) feels that IE has the better model. I wonder if instead of converting mouseenter/mouseleave (which is an incomplete conversion), we should use them as the basic event and convert mouseover/mouseout (as modulated by __isMouseOver)?
I'm curious as to when a sprite will not have a view? In particular, I'm worried about the non-parallelism that we will call __show any time the mouse goes over a sprite, but call __hide only if the sprite belongs to a view when the mouse leaves the bounding box of the sprite. LzInputTextSprite line 760: You changed _cancelblur to _cancelfocus and then commented out the whole. This seems misleading to me. Any reason to not just remove the commented out line(s)? Seems to me the setID method could be shared instead of duplicated. Approved if you address the above. On 2009-07-31, at 12:49EDT, Max Carlson wrote: > Change 20090731-maxcarlson-a by maxcarl...@bank on 2009-07-31 09:33:19 > PDT > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Redo mouse events for inputtext > > Bugs Fixed: LPP-8356 - IE inputtext can not recieve first click event > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Details: LzSprite, LzKeyboardKernel - Don't hide focused inputtexts. > > LzTextSprite - Update setID() > > LzInputTextSprite - Eliminate __LZinputclickdiv and use > __LZclickcontainerdiv instead. Eliminate IE-specific focus > workarounds in __hideIfNotFocused(). Eliminate Firefox specific > dom_breaks_focus quirk workarounds. Handle mouse events in > __setTextEvents() instead of a separate click div now that click divs > are hidden. Override setClickable() to only set the clickable > property, so extra click divs aren't created. Avoid setting > _cancelfocus/blur for now. Update setID(). > > LzInputText - Don't forward mouse events through inputtextevent(). > > Tests: See tests/lpp-8356.lzx?lzr=dhtml across browsers. Both > inputtexts are selectable with the mouse and by tabbing. The > clickable inputtext sends mouse events. > > Files: > M WEB-INF/lps/lfc/kernel/dhtml/LzKeyboardKernel.js > M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js > M WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js > M WEB-INF/lps/lfc/kernel/dhtml/LzInputTextSprite.js > M WEB-INF/lps/lfc/views/LzInputText.lzs > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20090731-maxcarlson-a.tar > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
