Approved!

[email protected] wrote:
> Change 20090817-Philip-4 by phi...@philip-dc on 2009-08-17 19:04:38 EDT
>     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/4.2
>     for http://svn.openlaszlo.org/openlaszlo/branches/4.2
> 
> Summary: Accessibility for radiobutton
> 
> New Features:
> 
> Bugs Fixed: LPP-7594 (partial)
> 
> Technical Reviewer: max
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> Details:
> 
> baselist.lzx: I found that setHilite() is not called when the radiogroup 
> gets focus.
> 
> radio.lzx:
> 
> radiogroup#oninit: aadescription and aactive are set if none was 
> specified. JAWS will read "X of Y" like an html page does.
> get_accState: uses focusable and the current focus view to return the 
> state.
> get_accDefaultAction: always returns "Check". This is the only allowed 
> value for a radio button.
> radiobutton#oninit: Generates EVENT_OBJECT_FOCUS and 
> EVENT_OBJECT_STATECHANGE if the item is selected.
> onselected: Only generate EVENT_OBJECT_FOCUS if the object was selected.
> updateFocus: Only generate accessibility events if hilited. I don't 
> think this method adds anything to accessibility but it doesn't seem to 
> change the output if it is present.
> setHilite: sets selected if the item is highlighted. This matches the 
> behavior of html where changing the current radiobutton selects it.
> 
> Note: This is /branches/4.2.
> 
> Tests:
> 
> Run the tests using only the keybaord.
> 
> See test case in the 8/17/2009 comment. This has 3 radiogroups. One is 
> enabled, one is invisible and one has focusable=false. Screen reading is 
> much closer to a simple html test case (also in jira).
> 
> I did see where the radiogroup with focusable=false is sometimes read by 
> JAWS. I think this is an issue with focus, not the radiobutton code.
> 
> Files:
> M      lps/components/lz/radio.lzx
> M      lps/components/base/baselist.lzx
> 
> http://svn.openlaszlo.org/openlaszlo/patches/20090817-Philip-4.tar

-- 
Regards,
Max Carlson
OpenLaszlo.org
_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews

Reply via email to