Approved!

[email protected] wrote:
> Change 20090820-Philip-8 by phi...@philip-dc on 2009-08-20 13:22:46 EDT
>     in /cygdrive/f/laszlo/svn/src/svn/openlaszlo/branches/4.2
>     for http://svn.openlaszlo.org/openlaszlo/branches/4.2
> 
> Summary: Add second parameter to LzLoader#doError
> 
> New Features:
> 
> Bugs Fixed: LPP-8346 (partial)
> 
> Technical Reviewer: max
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> Details:
> Load errors aren't passing error information to the onerror event. This 
> makes it difficult to understand why loads are failing. LzLoader#doError 
> calls the onerror handler and I added an error message parameter.
> 
> This changeset is for 4.2. On trunk there is another call to doError() 
> that should be modified.
> 
> 
> Tests:
> On a slow machine, or a machine made to run slow (see winThrottle for 
> example), this application will generate errors. When running this 
> application you should see errors such as, "onerror 
> canvas.mediaerrortimeout exceeded for 
> http://www.google.ca/intl/en_ca/images/logo.gif";. Without this changeset 
> no description of the error is shown.
> 
> 
> <canvas height="500" debug="true" mediaerrortimeout="100">
> 
>   <class name="test">
>     <handler name="oninit">
>     <![CDATA[
> 
> this.img.setSource("http://www.google.ca/intl/en_ca/images/logo.gif";);
>     ]]>
>     </handler>
> 
>     <view x="0" y="0" name="img" stretches="both" height="25" width="25">
>       <handler name="ontimeout">
>         Debug.write("ontimeout", this);
>       </handler>
>       <handler name="onerror" args="msg">
>         Debug.write("onerror", msg, this);
>       </handler>
>     </view>
>   </class>
> 
>   <handler name="oninit">
>   <![CDATA[
>     for (var i=0; i<50; i++) {
>       new lz.test();
>     }
>   ]]>
>   </handler>
> </canvas>
> 
> 
> 
> Files:
> M      WEB-INF/lps/lfc/kernel/swf/LzMediaLoader.lzs
> M      WEB-INF/lps/lfc/kernel/swf/LzLoader.lzs

-- 
Regards,
Max Carlson
OpenLaszlo.org
_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews

Reply via email to