Ok, I think I am understanding better here. When you get a right click, you are bringing the context-menu divs (representing the divs that have context menus) to the front and searching through them for the one under the mouse?
I guess this change works since Max approved it, but I would like to see something more rigorous that did not depend on 'magic numbers' like 1000 and 9999. I wonder if the context menu tree could just be always in front and made visible only when this search needs to happen? Is that a possibility? On 2009-08-25, at 20:46EDT, Henry Minsky wrote: > As I understand it, Max has made a hierarchy to emulate the behavior > of > right-clickability > in swf; in swf, the right clicks pass through everything except for > sprites > which have > contextmenu properties defined on them. So the right clicks need to > pass > transparently > through any views which are opaque or clickable. He made > > So I was trying to bring the 'contextmenudiv' tree up to the front, > and my > method was to put the main content div and the regular left-click div > temporarily to the back. > > > On Tue, Aug 25, 2009 at 8:18 PM, P T Withington > <[email protected]>wrote: > >> I'm not sure I understand what is going on here. Why do we change >> the >> z-order of the root when we are just looking to see if there is a >> context >> menu item to display? I would think if we needed to do any of this >> hijinx, >> it would be when you actually display the context menu. Maybe we >> just don't >> need this quirk any more? Or is it really that we just need to >> turn off >> globalClickable when we are searching for the context menu, in >> which case we >> should use that. >> >> I think we need input from Max on this. >> >> >> On 2009-08-25, at 17:38EDT, Henry Minsky wrote: >> >> Note: there's a regression I'm looking at (LPP-8421) which causes the >>> default canvas context menu not to appear if you click >>> right on the canvas. That's independent of this change. >>> >>> >>> Change 20090825-hqm-h by [email protected] on 2009-08-25 17:34:30 >>> EDT >>> in /Users/hqm/openlaszlo/trunk-clean >>> for http://svn.openlaszlo.org/openlaszlo/trunk >>> >>> Summary: fix for flickering swfs when right click menu is opened >>> >>> New Features: >>> >>> Bugs Fixed: LPP-8405 >>> >>> Technical Reviewer: ptw >>> QA Reviewer: max >>> Doc Reviewer: (pending) >>> >>> Documentation: >>> >>> Release Notes: >>> >>> Details: >>> >>> + when a right click is handled, instead of hiding the canvas >>> content and >>> click divs, >>> we set their z-order to negative values, to place them behind the >>> contextmenu click div. >>> >>> >>> Tests: >>> >>> + test case from bug report, does not flicker. >>> + test/contextmenu/lpp-6980.lzx , check that proper context menu >>> shows up, >>> regardless of whether other >>> opaque views are layered on top, check that embedded swf in <html> >>> tag >>> does not flicker when >>> context menu is opened >>> >>> Files: >>> M test/contextmenu/lpp-6980.lzx >>> M WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js >>> >>> >>> Changeset: >>> http://svn.openlaszlo.org/openlaszlo/patches/20090825-hqm-h.tar >>> >> >> > > > -- > Henry Minsky > Software Architect > [email protected] > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
