I'd love it if someone could write down an overview of what we are trying to do with the mouse handler. I feel like we are playing whack- a-mole here, adding a patch to a kludge to a workaround...
On 2009-09-02, at 05:57, André Bargull wrote: > Does everything work now? Because last time I wanted to change that > function to prevent event bubbling for all mouse-events, I couldn't do > it in the end, because OSX required bubbling, see our mail conversion > from May: > http://www.openlaszlo.org/pipermail/laszlo-dev/2009-May/021147.html > > > On 9/2/2009 2:57 AM, Max Carlson wrote: >> Ah - good catch! Thanks for that! >> >> André Bargull wrote: >>> I'm getting now two global onmousedown and two global onmouseup >>> events >>> in Firefox3.5 (Win). For your change to work, you need to change >>>> if (LzKeyboardKernel.__cancelKeys && e.keyCode == 0) { >>> to: >>>> if (LzKeyboardKernel.__cancelKeys) { >>> >>> See my mail "For Review: Change 20090602-bargull-GPN Summary: DHTML: >>> add "updateControlKeys" to LzKeyboardKernel", where I described the >>> differences for keyCode and mouse-events in different browers, >>> here's >>> the relevant snippet: >>> >>>> "keyCode" is set to 0 for mouse-events in IE, Opera, Safari, so you >>>> only need to test for keyCode==0 (Firefox is irrelevant in this >>>> case, >>>> because it sets keyCode to `undefined` for mouse-events). >>> >>> >>> On 9/1/2009 1:46 AM, Max Carlson wrote: >>>> Change 20090831-maxcarlson-2 by maxcarl...@bank on 2009-08-31 >>>> 16:37:48 PDT >>>> in /Users/maxcarlson/openlaszlo/trunk-clean >>>> for http://svn.openlaszlo.org/openlaszlo/trunk >>>> >>>> Summary: Prevent extra global onmouseup events in DHTML >>>> >>>> Bugs Fixed: LPP-8423 - DHTML: two global onmouseup events for >>>> each click >>>> >>>> Technical Reviewer: [email protected] >>>> QA Reviewer: hminsky >>>> >>>> Details: Don't set cancelBubble for onmouseup/down events - that's >>>> handled above... >>>> >>>> Tests: See testcase from LPP-8423. Also test with >>>> test/lfc/legals/keyboardandmouse.lzx?lzr=dhtml&debug=true >>>> >>>> Files: >>>> M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js >>>> >>>> Changeset: >>>> http://svn.openlaszlo.org/openlaszlo/patches/20090831-maxcarlson-2.tar >>>> >> > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
