LzSprite.__rootSprite.__LZdiv can be replaced by LzSprite.__rootSpriteContainer
I wish we had a better way to create defaults for attributes with setters than jamming them into the constructor args. You didn't really achieve your goal because you are still calling canvas.__LibraryLoaded. Would it be better to have a kernel API for installing that callback? On 2009-09-03, at 16:34, Max Carlson wrote: > Change 20090903-maxcarlson-P by maxcarl...@bank on 2009-09-03 13:19:47 > PDT > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Add APIs for setting load timeouts, explicit callback for > library loads > > Bugs Fixed: LPP-8444 - Remove explicit kernel references to the canvas > > Technical Reviewer: hminsky > QA Reviewer: ptw > > Details: LzMediaLoader, LzSprite - Add explicit sprite APIs for > LzSprite.setMediaLoadTimeout() and LzSprite.setMediaErrorTimeout(). > Read values stored in sprite. > > LzLibraryLoader, LzLibrary - Use shared callback for library load > events. > > LaszloCanvas - Add setters for medialoadtimeout and mediaerrortimeout > attributes, always call them when the canvas is constructed. Add > shared callback for library load events. > > Tests: IWFM > > Files: > M WEB-INF/lps/lfc/kernel/swf/LzMediaLoader.lzs > M WEB-INF/lps/lfc/kernel/swf/LzLibraryLoader.lzs > M WEB-INF/lps/lfc/kernel/swf/LzSprite.as > M WEB-INF/lps/lfc/kernel/dhtml/LzLibrary.js > M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js > M WEB-INF/lps/lfc/kernel/dhtml/LzMouseKernel.js > M WEB-INF/lps/lfc/kernel/swf9/LzLibrary.as > M WEB-INF/lps/lfc/kernel/swf9/LzSprite.as > M WEB-INF/lps/lfc/views/LaszloCanvas.lzs > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20090903-maxcarlson-P.tar > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
