Approved! André Bargull wrote: > Change 20090906-bargull-6jd by barg...@dell--p4--2-53 on 2009-09-06 > 17:29:52 > in /home/Admin/src/svn/openlaszlo/trunk > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: doc and code updates for LzView > > New Features: > > Bugs Fixed: LPP-8450 (Update reference page for LzView / Remove stale > code in LzView), LPP-4570 (clickRegion attribute is not settable at > runtime.) > > Technical Reviewer: max > QA Reviewer: (pending) > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Details: > This changeset contains several changes for LzView: > - updated references from Lz* (e.g. LzFocus) to lz.* (lz.Focus) > - removed all @initargs, they're unused and the documentation is already > in place at the attributes > - "capabilities" is read-only (except for the kludge in > base/swatchview.lzx) > - rearranged $debug blocks to avoid empty blocks in non-debug builds > (e.g. "else { if ($debug) ..." to "else if ($debug)") > - added @lzxdefault where applicable (focusable, fgcolor, bgcolor, > clickable, playing) > - "align" isn't actually initialize-only, so removed @keywords final > - "clickregion" is actually initialize-only, so added @keywords final. > It's also only implemented for swf8, so added @runtimes as2, too. > - updated all calls to LzView.__warnCapability which referred to > deprecated setters > - removed stale attributes from pre 4.0 days, all attributes are now > used solely in the swf8-kernel (__LZclickregion, checkPlayStatusDel, > updatePlayDel, __LZbgColorO, __LZbgRef, __LZbuttonRef, > __LZisBackgrounded, __LZmaskClip, __LZmovieClipRef, __LZsubUniqueNum) > - "pixellock" used wrong annotation (@modifiers), updated to @keywords > - removed duplicated doc on $lzc$set_clickable, I still wonder why it > was added..? > - deprecated "getContextMenu()", directly accessing the property is the > way we want things > > Questions: > - what are "__LZcaloffset" and "__LZisView"? There are completely unused > in the LFC, so not swf8-kernel cruft like above.. > > > Tests: > > Files: > M WEB-INF/lps/lfc/views/LaszloView.lzs > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20090906-bargull-6jd.tar >
-- Regards, Max Carlson OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
