Approved.  But then, I approved the change that introduced this bug,  
so it's not clear you should trust me:

> r10509 | dda | 2008-07-29 17:33:54 -0400 (Tue, 29 Jul 2008) | 44 lines
>
> Change 20080729-dda-j by [email protected] on 2008-07-29 16:52:27 EDT
>     in /Users/dda/laszlo/src/svn/openlaszlo/trunk-doc
>     for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Fix quick index for small apps
>
> New Features:
>
> Bugs Fixed: LPP-6714
>
> Technical Reviewer: ptw (pending)
> QA Reviewer: promanik (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
>     The top level quick index is produced/digested from the laszlo- 
> explorer
>     nav.xml menu.  It appears that laszlo-explorer may have changed  
> to use an
>     application runner script (loading.jsp) that has some smarts.
>     Small Applications are referred to in nav.xml using html names,  
> like
>     weather.html that shows the application running in a wrapper  
> page (weather.html).
>
>     To keep the app running transparent to the user, the change for  
> the quick index
>     uses the lzx names (e.g. weather.lzx), stealing these names from  
> the file shown
>     when source is displayed.
>
>     Another valid solution could be to modify Small App entries in  
> nav.xml so that they
>     have action="popup" (just as LZPIX has).  This would be a  
> simpler solution, but
>     changes the behavior of the small apps laszlo explorer.  I don't  
> know the exact
>     consequences of this solution, so I didn't use it.
>
> Tests:
>     To build, from the root svn directory: ant laszlo-explorer, then
>     open http://localhost:8080/trunk/quick-index.html in the browser
>     (don't open quick-index.html using file:..../quick-index.html)
>     It appears that this quick-index.html will overwrite the top level
>     index.html at some point during the release build.
>
>     Tried opening all small apps + sources.
>

On 2009-09-28, at 16:31, André Bargull wrote:

> Change 20090928-bargull-W0J by barg...@dell--p4--2-53 on 2009-09-28  
> 22:28:04
> in /home/Admin/src/svn/openlaszlo/trunk
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: remove debug=true from link to small application in  
> index.html
>
> New Features:
>
> Bugs Fixed: LPP-8511 (All the "small applications" are run in debug  
> mode)
>
> Technical Reviewer: ptw
> QA Reviewer: (pending)
> Doc Reviewer: (pending)
>
> Documentation:
>
> Release Notes:
>
> Details:
> Just removed the entry which added the debug flag to the link.
>
>
> Tests:
> ant laszlo-explorer
> open index.html in browser
>
> Files:
> M docs/src/quick-index.xslt
>
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20090928-bargull-W0J.tar
>


_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews

Reply via email to