You did not address my point that tintcolor and setColorTransform need to coordinate. I think this will just lead to bug reports.
I don't really understand why if tintcolor and fgcolor are mutually exclusive, we don't just make fgcolor smarter. But if we are going to have 3 ways to color a view, it seems they ought to be consistent. So setting a color transform needs to update tintcolor. Why not allow tintcolor to be an arbitrary color specification, as we do with fgcolor, rather than hardwiring it to # format? On 2009-09-26, at 09:39, Max Carlson wrote: > Change 20090918-maxcarlson-4 by [email protected] on 2009-09-18 > 06:54:12 PDT > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: UPDATED ONE LAST TIME - Add setter for tintcolor > > Bugs Fixed: LPP-7963 - 'fgcolor' Attribute Not Applied To Image > Resources > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Details: lzunit-lzutils - Add test for round tripping a hex value with > alpha component. > > LzUtils - Fix typo in comments. Update LzColorUtils to deal with > alpha components properly. > > LaszloView - Add a tintcolor attribute and setter to make it easier to > apply a hexadecimal color value as a color transform. If called with > null or '', reset the transform. When setting tintcolor, warn if > fgcolor is set. When setting fgcolor, warn if tintcolor is set. > > Tests: > <canvas> > <hbox> > <button name="foo" onclick="this.setAttribute('coloroffset', > '#ff00ff')">Set color offset</button> > <button onclick="parent.foo.setAttribute('coloroffset', > '')">Clear color offset</button> > </hbox> > </canvas> > > > Files: > M test/lfc/lzunit-lzutils.lzx > M WEB-INF/lps/lfc/services/LzUtils.lzs > M WEB-INF/lps/lfc/views/LaszloView.lzs > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20090918-maxcarlson-4.tar > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
