This looks good to me. Approved! André Bargull wrote: > Change 20090929-bargull-Diz by barg...@dell--p4--2-53 on 2009-09-29 > 00:23:57 > in /home/Admin/src/svn/openlaszlo/trunk > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: update components to avoid using "onconstruct", "oninit" and > "ondestroy" > > New Features: > > Bugs Fixed: LPP-399 (baseform components use incorrect init and > construct methods) > > Technical Reviewer: max > QA Reviewer: (pending) > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Details: > Replaced "onconstruct", "oninit", "ondestroy" in favor of "construct", > "init", "destroy". This makes it easier to control instantiation for > subclasses and should give a small performance benefit because it avoids > creating a delegate. > Also replaced super calls using "Function.prototype.apply" with the > direct form, because it's faster that way. > > > Tests: > inspection > > Files: > M lps/components/lzunit/lzunit.lzx > M lps/components/lz/radio.lzx > M lps/components/lz/list.lzx > M lps/components/lz/windowpanel.lzx > M lps/components/extensions/html.lzx > M lps/components/utils/layouts/reverselayout.lzx > M lps/components/utils/replicator/replicator.lzx > M lps/components/av/rtmpstatus.lzx > M lps/components/base/basetabelement.lzx > M lps/components/base/image.lzx > M lps/components/base/basetree.lzx > M lps/components/base/basewindow.lzx > M lps/components/base/basetrackgroup.lzx > M lps/components/base/baseslider.lzx > M lps/components/base/baseformitem.lzx > M lps/components/base/basetabs.lzx > M lps/components/base/baseform.lzx > M lps/components/base/basegridcolumn.lzx > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20090929-bargull-Diz.tar >
-- Regards, Max Carlson OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
