Approved! On 2009-10-08, at 08:48, Max Carlson wrote:
> Change 20090918-maxcarlson-4 by [email protected] on 2009-09-18 > 06:54:12 PDT > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: UPDATED ONCE AGAIN - Add setter for tintcolor > > Bugs Fixed: LPP-7963 - 'fgcolor' Attribute Not Applied To Image > Resources > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Details: Addresses ptw's feedback: setColorTransform() keeps tintcolor > in sync, and tintcolor setter accepts any color spec. > > lzunit-lzutils - Add test for round tripping a hex value with alpha > component. > > LzUtils - Fix typo in comments. Update LzColorUtils to deal with > alpha components properly. > > LaszloView - Add a tintcolor attribute and setter to make it easier to > apply a hexadecimal color value as a color transform. If called with > null or '', reset the transform. When setting tintcolor, warn if > fgcolor is set. When setting fgcolor, warn if tintcolor is set. When > calling setColorTransform(), update tintcolor to an appropriate hex > value. > > Tests: The first two buttons set the same color. test/lfc/lzunit- > lzutils.lzx passes. > <canvas> > <hbox> > <button name="foo" onclick="this.setAttribute('tintcolor', > '#ff00ffff')">Set tintcolor </button> > <button onclick="parent.foo.setColorTransform({rb: 255, gb: > 0, bb: 255, ab: 255}); Debug.warn('this.tintcolor', > parent.foo.tintcolor)">Set color transform</button> > <button onclick="parent.foo.setAttribute('tintcolor', > '')">Clear tintcolor</button> > </hbox> > </canvas> > > > > Files: > M test/lfc/lzunit-lzutils.lzx > M WEB-INF/lps/lfc/services/LzUtils.lzs > M WEB-INF/lps/lfc/views/LaszloView.lzs > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20090918-maxcarlson-4.tar > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
