I have to un-approve this because it is breaking the nightly builds:
[exec] testing test/lztest/lztest-selftest.lzx...........
[exec] Compiling: test/lztest/lztest-selftest.lzx to test/lztest/
lztest-selftest.js
[exec] js: "lps/includes/lfc/LFCdhtml-debug.js", line 3071:
uncaught JavaScript runtime exception: TypeError: Cannot read property
"isIE" from undefined
[exec] at lps/includes/lfc/LFCdhtml-debug.js:3071
[exec] at tmp/test_lztest_lztest-selftest.js:57
I agree that we should put all the debugger annotations of underlying
platform features in one place.
On 2009-10-09, at 16:01, André Bargull wrote:
> Approved!
>
> Can someone add an improvement request, in order to create a single
> file where all these additional 'settings' are done? Because at the
> moment they're spread all over the place, e.g. '_dbg_name' for
> global is added in lfc/debugger/LzDebug.lzs. A more obvious place
> would be appreciated!
>
>
> On 10/8/2009 10:47 PM, Henry Minsky wrote:
>> Change 20091008-hqm-e by [email protected] on 2009-10-08 16:41:55
>> EDT
>> in /Users/hqm/openlaszlo/trunk-clean/WEB-INF/lps/lfc
>> for http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc
>> Summary: IE7: Error object in DHTML needs smarter toString method
>> New Features:
>> Bugs Fixed: LPP-8539
>> Technical Reviewer: ptw
>> QA Reviewer: andre
>> Doc Reviewer: (pending)
>> Documentation:
>> Release Notes:
>> Details:
>> Add more informative toString method to IE7 Error class
>> Tests:
>> In IE7/DHTML, new Error('foo').toString() should print out as
>> «Error#0| Error: foo»
>> Files:
>> M debugger/platform/dhtml/LzDebug.js
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20091008-hqm-e.tar
_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
