approved! On Sat, Oct 10, 2009 at 11:01 AM, André Bargull <[email protected]>wrote:
> Still waiting for your response for this change :-) > > > > On 9/28/2009 10:44 PM, André Bargull wrote: > >> Change 20090928-bargull-OGV by barg...@dell--p4--2-53 on 2009-09-28 >> 22:35:41 >> in /home/Admin/src/svn/openlaszlo/trunk >> for http://svn.openlaszlo.org/openlaszlo/trunk >> >> Summary: add _dbg_name back to LzDataElementMixin, LzDataText >> >> New Features: >> >> Bugs Fixed: LPP-8501 (lz.datapointer#_dbg_name is broken) >> >> Technical Reviewer: henry >> QA Reviewer: (pending) >> Doc Reviewer: (pending) >> >> Documentation: >> >> Release Notes: >> >> Details: >> _dbg_name() was removed from LzDataElementMixin, because the compiler >> didn't added the required "override" keyword for the >> LzDataElementMixin+LzNode class. But _dbg_name() has been moved to the >> LzNode.prototype, so the "override" keyword is no longer necessary and >> therefore we can re-enable _dbg_name() for LzDataElementMixin. Also added >> _dbg_name() to LzDataText, otherwise LzDatapointer#_dbg_name() fails if the >> datapointer points to an instance of LzDataText. >> The change may be a bit quirky, but works at least until LPP-6705 is >> finished. >> >> >> Tests: >> lzx> new lz.datapointer(null, {p: new lz.DataElement("item")})._dbg_name() >> lzx> new lz.datapointer(null, {p: new lz.DataText("item")})._dbg_name() >> >> Files: >> M WEB-INF/lps/lfc/data/LzDatapointer.lzs >> M WEB-INF/lps/lfc/data/LzDataText.lzs >> M WEB-INF/lps/lfc/data/LzDataElement.lzs >> >> Changeset: >> http://svn.openlaszlo.org/openlaszlo/patches/20090928-bargull-OGV.tar >> >> >> -- Henry Minsky Software Architect [email protected]
_______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
