Not approved. This is not right because updateText calls the setter which will set the "rollback" value of the field. Entering text should not do that (which is why the direct call to setValue.). Also, your change will recurse because the parent setter calls the setter for the inner field.
You need to remodularize somehow so that you can update the parent's text and send the event without clobbering the rollback. On Oct 13, 2009, at 4:33, Max Carlson <[email protected]> wrote: > Change 20091013-maxcarlson-J by [email protected] on 2009-10-13 > 01:18:17 PDT > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Send ontext events for edittext > > Bugs Fixed: LPP-7990 - edittext doesn't dispatch "ontext" event after > change > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Details: Call updateText() when field's text attribute changes. > > Tests: See LPP-7990 > > Files: > M lps/components/lz/edittext.lzx > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20091013-maxcarlson-J.tar > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
