Please add a quirk in IE for the fact that we need to set clip explicitly to 'clip(auto auto auto auto)' instead of being able to set '' and have it inherit from the CSS. You could also try setting to null in IE, which may be more efficient - but it should still have a quirk even if that works.
Can you add a comment to LzTextSprite.prototype.setHeight() that explains why you need to check if the div's className is lzswfinputtextmultiline? Otherwise, approved! Henry Minsky wrote: > Change 20091013-hqm-T by [email protected] on 2009-10-13 22:50:53 EDT > in /Users/hqm/openlaszlo/trunk6 > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: fix bug in DHTML when switching from inputtext from single- > line to multiline > > New Features: > > Bugs Fixed: LPP-8555 > > Technical Reviewer: ptw > QA Reviewer: max > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Details: > > +LzTextSprite.setHeight: when in inputtext and multiline, make > sure that the height is calculated properly for an input text field, > taking into account the scrollbars that will be preset. > > + LzSprite.__updateClip: use 'rect(auto auto auto auto)' instead of '' > to set default clip (IE7 barfs on empty string value) > > + LzText, LzInputText: remove 'sizeToHeight', it was not being > maintained consistently, use !hassetheight instead. > > Tests: > > + test case from bug report > + debugger input eval field looks OK when expanded to multiline mode > + smokecheck DHTML > + calendar DHTML > > Files: > M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js > M WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js > M WEB-INF/lps/lfc/views/LzInputText.lzs > M WEB-INF/lps/lfc/views/LzText.lzs > > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20091013-hqm-T.tar > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews -- Regards, Max Carlson OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
