Well on that basis I approve your change. But I think we still have an improvement here, which is to document that people should not use LPS to deliver their apps. Ever.
On 2009-10-14, at 15:43, Henry Minsky wrote: > well, 'never' actually means 'compile it once, and never check the > file > modification dates after that'. > > > On Wed, Oct 14, 2009 at 3:12 PM, Henry Minsky > <[email protected]>wrote: > >> very good questions... hmm. >> >> I'll check and see why the compiler is running at all. >> >> >> On Wed, Oct 14, 2009 at 2:04 PM, P T Withington <[email protected] >> >wrote: >> >>> Not approved yet: >>> >>> What is the 'deploy' version of properties supposed to do? >>> >>> Should it really be a separately maintained list, or should it be >>> generated by the build? Or, maybe it is totally stale and should >>> just go >>> away, since we don't recommend using the LPS server for deployment? >>> >>> While this change fixes the immediate bug the user filed about (null >>> pointer), it doesn't solve the larger bug: apparently they were >>> expecting >>> that by using the deploy version of properties nothing would ever be >>> compiled, so why was his stuff being compiled in the first place? >>> >>> >>> >>> On 2009-10-14, at 13:20, Henry Minsky wrote: >>> >>> Change 20091014-hqm-T by [email protected] on 2009-10-14 13:18:01 >>> EDT >>>> in /Users/hqm/openlaszlo/trunk6 >>>> for http://svn.openlaszlo.org/openlaszlo/trunk >>>> >>>> Summary: update the 'deploy' version of lps.properties >>>> >>>> New Features: >>>> >>>> Bugs Fixed: LPP-7705 >>>> >>>> Technical Reviewer: ptw >>>> QA Reviewer: (pending) >>>> Doc Reviewer: (pending) >>>> >>>> Documentation: >>>> >>>> Release Notes: >>>> >>>> Details: >>>> >>>> + default compiler.runtime.dir in LPS.java >>>> >>>> + merge over some of the newer lps.properties >>>> >>>> Tests: >>>> >>>> Files: >>>> M WEB-INF/lps/config-deploy/lps.properties >>>> M WEB-INF/lps/server/src/org/openlaszlo/server/LPS.java >>>> >>>> Changeset: >>>> http://svn.openlaszlo.org/openlaszlo/patches/20091014-hqm-T.tar >>>> _______________________________________________ >>>> Laszlo-reviews mailing list >>>> [email protected] >>>> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews >>>> >>> >>> >> >> >> -- >> Henry Minsky >> Software Architect >> [email protected] >> >> >> > > > -- > Henry Minsky > Software Architect > [email protected] > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
