On Tue, Oct 20, 2009 at 12:11 PM, P T Withington <[email protected]>wrote:
> It seems to me that you need to override `set clip` in LzText to turn off > scrollevents if clip is set to false, and in `set scrollevents` warn if they > are turned on when clipping is off. > > I can see that this is a little problematic, since you don't know what > order these attributes will be initialized in at construct time. I guess > you have to conditionalize the warning in the setter on `inited`. Yes that was the problem, the order is not deterministic whether clip or scrollevents get set first at construct time. > > > On 2009-10-20, at 11:44, Henry Minsky wrote: > > Change 20091020-hqm-Y by [email protected] on 2009-10-20 11:40:25 EDT >> in /Users/hqm/openlaszlo/trunk-clean >> for http://svn.openlaszlo.org/openlaszlo/trunk >> >> Summary: add warning about clip and scrollevents, make clipping >> runtime settable >> >> New Features: >> >> Bugs Fixed: LPP-8562 >> >> Technical Reviewer: max >> QA Reviewer: ptw >> Doc Reviewer: (pending) >> >> Documentation: >> >> Release Notes: >> >> Details: >> >> + LzText: put in warning when LzText has scrollevents=true but >> clip=false >> + LzView: add setter and onclip event for the 'clip' attribute >> >> Tests: >> >> + warning for non-clipped text view: >> <canvas height="80%"> >> <text x="100" y="50" name="tField" multiline="true" width="300" >> height="100" scrollevents="true"/> >> <inputtext x="500" y="50" name="ifield" multiline="true" >> width="300" height="100" scrollevents="true"/> >> </canvas> >> >> warning should print in debugger about 'clip' needing to be set for >> the first text view. >> >> >> + test that you canset clip attribute at runtime >> <canvas height="80%"> >> <view bgcolor="#cccccc" width="100" height="100" clip="true" >> id="v1"> >> <handler name="onclick"> >> this.setAttribute('clip', !this.clip); >> </handler> >> <text text="${'clip: '+parent.clip}"/> >> <view bgcolor="red" width="500" y="40" height="20"/> >> </view> >> </canvas> >> >> >> Files: >> M WEB-INF/lps/lfc/views/LzText.lzs >> M WEB-INF/lps/lfc/views/LaszloView.lzs >> M lps/components/debugger/newcontent.lzx >> >> Changeset: >> http://svn.openlaszlo.org/openlaszlo/patches/20091020-hqm-Y.tar >> _______________________________________________ >> Laszlo-reviews mailing list >> [email protected] >> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews >> > > -- Henry Minsky Software Architect [email protected]
_______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
