approved
On Wed, Oct 21, 2009 at 1:22 AM, Max Carlson <[email protected]> wrote:
> Yes - good point! Otherwise, approved?
>
> Henry Minsky wrote:
>
>> For those changes, isn't the 'hassetheight' value going to be always false
>> in those cases, given that it's inside of a
>> "if (!this.hassetheight) { ... }" block ? So could the code could just set
>> it to false after calling setHeight()?
>>
>>
>>
>>
>> On Tue, Oct 20, 2009 at 11:37 PM, Max Carlson <[email protected]<mailto:
>> [email protected]>> wrote:
>>
>> Change 20091020-maxcarlson-O by [email protected] on 2009-10-20
>> 20:33:37 PDT
>> in /Users/maxcarlson/openlaszlo/trunk-clean
>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: Fix height measurement of text in DHTML
>>
>> Bugs Fixed: LPP-8566 - Multiline text views getting clipped
>>
>> Technical Reviewer: hminsky
>> QA Reviewer: ptw
>>
>> Details: Cache and restore the value of hassetheight when measured
>> height changes, to prevent subsequent measurements from being ignored.
>>
>> Tests: See LPP-8566
>>
>> Files:
>> M WEB-INF/lps/lfc/views/LzText.lzs
>>
>> Changeset:
>> http://svn.openlaszlo.org/openlaszlo/patches/20091020-maxcarlson-O.tar
>>
>>
>>
>>
>> --
>> Henry Minsky
>> Software Architect
>> [email protected] <mailto:[email protected]>
>>
>>
>>
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Laszlo-reviews mailing list
>> [email protected]
>> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
>>
>
> --
> Regards,
> Max Carlson
> OpenLaszlo.org
>
--
Henry Minsky
Software Architect
[email protected]
_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
