ok then, approved
On Wed, Nov 11, 2009 at 10:38 PM, Max Carlson <[email protected]> wrote:
> It does seem to be necessary. That's one of the reasons I changed
> clickregion to a Sprite - so it can also be assigned to the hitArea
> property.
>
> Henry Minsky wrote:
>
>> I;ve got one question about this, which is that in the drawview code you
>> set both the
>> 'hitArea' property of the sprite to be the clickregion shape, and also you
>> set the 'hitTestState' of the clickbutton object to point to the
>> clickregion. Is it really necessary to set both?
>>
>>
>> function clipButton() {
>> if (! this.clickable) this.sprite.setClickable(true);
>> var clickregion = this.sprite.clickregion
>> if (! this.clickcontext) {
>> this.sprite.hitArea = clickregion;
>> this.sprite.clickbutton.hitTestState = clickregion;
>> this.clickcontext = clickregion.graphics;
>>
>> On Wed, Nov 11, 2009 at 9:19 PM, Max Carlson <[email protected] <mailto:
>> [email protected]>> wrote:
>>
>> Change 20091111-maxcarlson-o by maxcarl...@bank on 2009-11-11
>> 18:00:32 PST
>> in /Users/maxcarlson/openlaszlo/trunk-clean
>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: Fix drawview clipPath() and clipButton() for swf8, 9 and 10
>>
>> Bugs Fixed: LPP-8596 - Add clipPath() support for drawviews in swf9/10
>>
>> Technical Reviewer: hminsky
>> QA Reviewer: [email protected] <mailto:[email protected]>
>>
>>
>> Details: LzSprite.as - Use a Sprite instead of a Shape for the
>> clickregion to get more flexibility over hit testing.
>>
>> drawview - Refactor clipPath() and clipButton() to use a shared
>> __drawPath() method. Add AS3 implementations for clearMask(),
>> clipPath() and clipButton(). Update warnings for other missing as3
>> methods to show the correct runtime. Reset the mask scale after
>> drawing for as2 clipPath().
>>
>> Tests: Dragging triangular red drawviews now shows correct mouse and
>> clip regions in swf8/9/10.
>>
>> Files:
>> M WEB-INF/lps/lfc/kernel/swf9/LzSprite.as
>> M lps/components/extensions/drawview.lzx
>>
>> Changeset:
>> http://svn.openlaszlo.org/openlaszlo/patches/20091111-maxcarlson-o.tar
>>
>>
>>
>>
>> --
>> Henry Minsky
>> Software Architect
>> [email protected] <mailto:[email protected]>
>>
>>
>>
> --
> Regards,
> Max Carlson
> OpenLaszlo.org
>
--
Henry Minsky
Software Architect
[email protected]
_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
