André makes a good point. If we remove type declarations that are already "in the wild", we will break anyone's code that is already declaring those types.
For now, we should just freeze all API type declarations the way they are until we fix LPP-6080. So, not approved. On 2009-11-15, at 10:55, André Bargull wrote: > On the one hand the reporter said that it works in the nightly builds: >> seems fixed in 4.7.x testing with 13 november build > > And on the other hand people using the 4.6 release for AS3 development must > specify argument and return value types, if you remove those now, they need > to remove the typing again for the 4.7 release. So I think we're stuck with > it... > > > P T Withington wrote: >> I'm not sure I understand why you are removing the types. The complaint was >> that the swf8 compiler is doing something wrong with the types, so why >> aren't we finding the bug there? Presumably, it just needs to learn to >> ignore the type declaration? >> >> On 2009-11-14, at 20:43, Max Carlson wrote: >> >> >>> Change 20091114-maxcarlson-D by maxcarl...@bank on 2009-11-14 17:38:34 PST >>> in /Users/maxcarlson/openlaszlo/trunk-clean >>> for http://svn.openlaszlo.org/openlaszlo/trunk >>> >>> Summary: Remove argument and return value types from LzView so their >>> methods can be overridden >>> >>> Bugs Fixed: LPP-8598 - incompatible overriding swf9/10 -> >>> returns="someType" make swf8 crazy >>> >>> Technical Reviewer: hminsky >>> QA Reviewer: ptw >>> >>> Details: Comment out argument and return value types. >>> Tests: See LPP-8598 >>> >>> Files: >>> M WEB-INF/lps/lfc/views/LaszloView.lzs >>> >>> Changeset: >>> http://svn.openlaszlo.org/openlaszlo/patches/20091114-maxcarlson-D.tar >>> >>> _______________________________________________ >>> Laszlo-reviews mailing list >>> [email protected] >>> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews >>> >> >> >> _______________________________________________ >> Laszlo-reviews mailing list >> [email protected] >> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews >> >> _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
