Yes, I think I had a stale build. It's working now! Approved!
P T Withington wrote: > What do you think about me at least checking in what I have got so we can > make sure you and I are running the same thing? > > On 2009-11-19, at 16:16, Max Carlson wrote: > >> There's another kind of duplicate class definition warning: >> >> I've been using this ant script to rebuild the libraries: >> >> $ cd jade/client >> $ ant build-libraries -Drelease.id=1.0 >> >> To see the error right away, you can run this (from jade/client/): >> $ lzc -c components/window/dialog/library.lzx >> >> Compiling: components/window/dialog/library.lzx to >> components/window/dialog/library.gz >> Compilation errors occurred: >> ../../jade/client/components/wtstylishbutton/library.lzo:24:42: duplicate >> class definitions for tooltip; also defined at >> incubator/tooltip/tooltip.lzx:28 >> >> components/wtstylishbutton/library.lzo (gunzipped) reads: >> <!-- This is a binary library. Not meant for human consumption. --> >> <!-- DO NOT EDIT THIS FILE. Edit the source and recompile with `-c` --> >> <library includes="wtstylishbutton.lzx"> >> <include href='../../../../lps/components/incubator/tooltip/tooltip.lzx' /> >> <include href='../../../../lps/components/base/basebutton.lzx' /> >> ... >> <interface name='tooltip' extends='node'> >> ... >> >> Is there a way to get a look at the partial compiler output e.g. >> components/wtstylishbutton/library.lzo? It's not clear to me where in >> components/wtstylishbutton/library.lzx the include tooltip is added again - >> I grepped components/wtstylishbutton/ and these direct includes with no luck >> - it's difficult to recurse through the includes to find it and know how to >> address the problem: >> >> <library> >> <!--// DEPENDENCIES //////////////////////////////////////////////////// >> --> >> <include href="../../mtext"/> >> <include href="../../panel"/> >> <include href="../../wtstylishbutton"/> >> <include href="../../mcheckbox"/> >> ... >> >> >> P T Withington wrote: >>> [UPDATE^2 >>> This update eliminates the duplicate class error and makes the <switch> tag >>> just issue a warning. When it sees a <switch>, it processes the otherwise >>> clause and keeps going.] >>> Change 20091118-ptw-8 by [email protected] on 2009-11-18 16:53:36 EST >>> in /Users/ptw/OpenLaszlo/trunk-2 >>> for http://svn.openlaszlo.org/openlaszlo/trunk >>> Summary: Binary compiler tweaks >>> Bugs Fixed: >>> LPP-8624 <script>when ($runtimeflag) {...}</script> crashes library compiler >>> LPP-8603 forward reference from instance-class in .lzo file gives error in >>> swf8 and dhtml runtimes >>> LPP-8623 Library compiler should complain about <when/> tags >>> Technical Reviewer: max, hminsky (pending) >>> QA Reviewer: fellenberger, mdemmon (pending) >>> Details: >>> LzNode: Learn how to print nodes that are instances of anonymous >>> classes. >>> ClassModel: Give anonymous classes a useful tagname for >>> debugging. Remove erroneous test that prevented forward >>> references to classes in binary libraries. Only output tagname >>> for debugging. >>> Parser: For now, <switch> is not permitted in a binary library. >>> ToplevelCompiler: Permit binary compiling an autoinclude. >>> CodeGenerator, JavascriptGenerator: Match modularization of >>> GenericVisitor, permit compile-time conditionals in user code. >>> Compiler, Transformer: Work in progress, just check-pointing. >>> GenericVisitor: Add missing visitor, fix a few brain-ohs. >>> Tests: >>> Test cases from bug reports. smokecheck. QA Reviewers will >>> verify webtop SDK works. >>> Files: >>> M WEB-INF/lps/lfc/core/LzNode.lzs >>> M WEB-INF/lps/server/src/org/openlaszlo/sc/JavascriptGenerator.java >>> A WEB-INF/lps/server/src/org/openlaszlo/sc/Transformer.java >>> M WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java >>> M WEB-INF/lps/server/src/org/openlaszlo/sc/CodeGenerator.java >>> M WEB-INF/lps/server/src/org/openlaszlo/sc/GenericVisitor.java >>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/ToplevelCompiler.java >>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java >>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/Parser.java >>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20091118-ptw-8.tar >> -- >> Regards, >> Max Carlson >> OpenLaszlo.org > -- Regards, Max Carlson OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
