Approved!

P T Withington wrote:
> Give this a try.  I was able to debug compile lzmail with just 768m with this 
> change.
> 
> ---
> 
> Change 20091202-ptw-D by [email protected] on 2009-12-02 18:56:46 EST
>     in /Users/ptw/OpenLaszlo/trunk
>     for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Slim down debug compiles
> 
> Bugs Fixed: LPP-8636 lzc -c --debug --backtrace should work
> 
> Technical Reviewer: hminsky (pending)
> QA Reviewer: max (pending)
> 
> Overview:
> 
>     Implement Don's suggestion to himself to encode file annotations
>     rather than inserting the full file name over and over into the
>     intermediate file.
> 
> Details:
> 
>     ParseTreePrinter: Encode file names in the intermediate file.
>     Adapt the line annotation optimizations from binary libraries to
>     the dhtml back end.
> 
>     ToplevelCompiler: Don't add autoincludes that are in the library
>     you are compiling.  Ever.
> 
>     CompilationEnvironment: Ensure the application base is canonical
>     so that getUserPathname works correctly.
> 
> Tests:
>     Compiled lzmail with --debug and --bactrace using .lzo's compiled
>     with --debug and --backtrace.  Did not run out of memory with
>     JAVA_OPTS=-ea -Xmx768m.  Visual inspection of the .js file.
>     ant lztest and smokecheck on all platforms.
> 
> Files:
> M      WEB-INF/lps/server/src/org/openlaszlo/sc/ParseTreePrinter.java
> M      WEB-INF/lps/server/src/org/openlaszlo/compiler/ToplevelCompiler.java
> M      
> WEB-INF/lps/server/src/org/openlaszlo/compiler/CompilationEnvironment.java
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20091202-ptw-D.tar

-- 
Regards,
Max Carlson
OpenLaszlo.org
_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews

Reply via email to