Hm... On 2009-12-04, at 18:06, Max Carlson wrote:
> The compiler didn't catch the 'boxmodel' autoinclude. It worked for a > top-level mixin instance, e.g.: > > <view with="boxmodel"/> > > P T Withington wrote: >> Eh? That's part of Henry's patch, right? >> On 2009-12-04, at 17:47, Max Carlson wrote: >>> Oops - not approved yet. This still fails: >>> >>> <view> >>> <view with="boxmodel"/> >>> </view> >>> >>> P T Withington wrote: >>>> [I think this is trivially correct, so I'm checking it in to unblock max.] >>>> Change 20091204-ptw-E by [email protected] on 2009-12-04 16:07:41 EST >>>> in /Users/ptw/OpenLaszlo/trunk-2 >>>> for http://svn.openlaszlo.org/openlaszlo/trunk >>>> Summary: Look for auto-included mixins in 'instance classes' >>>> Bugs Fixed: LPP-8657 Autoincludes not working for instance mixins >>>> Technical Reviewer: hminsky (pending) >>>> QA Reviewer: max (pending) >>>> Details: >>>> Now that instances can use mixins, the auto-include reference >>>> finder needs to look for them. >>>> Tests: >>>> Inspectin >>>> Files: >>>> M WEB-INF/lps/server/src/org/openlaszlo/compiler/ToplevelCompiler.java >>>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20091204-ptw-E.tar >>> -- >>> Regards, >>> Max Carlson >>> OpenLaszlo.org > > -- > Regards, > Max Carlson > OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
