Approved! This is great! I'd like to figure out a better way to conditionalize the if ($swf8) funnybizness - can you comment that part better?
On 12/11/09 9:12 AM, Henry Minsky wrote: > UPDATED > > Change 20091211-hqm-e by [email protected] on 2009-12-11 00:10:30 EST > in /Users/hqm/openlaszlo/trunk6 > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: make mega-test ("ant runlzunit") work in swf10, cleans up it's > windows after it > > New Features: > > Bugs Fixed: > > Technical Reviewer: ptw > QA Reviewer: max > Doc Reviewer: (pending) > > Documentation: > > Release Notes: > > Overview: > > > Details: > > + test/lztest/lztest-selftest.lzx: needed some tweaks for swf10 > > + test/lztest/lztest-class-impl.lzx: this test really applies only to our > own class system implementation for as2 and dhtml, so I made it a no-op for > as3. > > + added a simple test of .lzo's, right now it just defines a simple > class in a .lzo, and then checks an attribute value of an instance. We > can make this handle more complex screw cases next. > > + ant runlzunit will now close the window containing each unit test after it > completes > (works for Firefox on OSX). If run on Winblows, you need to set this Firefox > pref: > user_pref("dom.allow_scripts_to_close_windows", true); > > + some unit tests still needed to be updated for the automatic cross platform > test > harness (needed to add 'addTests' methods) > > > Tests: > > ant runlzunit now runs tests in all three runtimes, and passes > > Files: > A test/lztest/lztest-lzo-main.lzx > A test/lztest/lzo-lib.lzx.proto > M test/lztest/lztest-selftest.lzx > M test/lztest/rhino.txt > M test/lztest/lztest-class-impl.lzx > M test/components/base/lzunit-basecomponent.lzx > M test/components/base/lzunit-baseslider.lzx > M test/lfc/lzunit-timer.lzx > M build-tools/runlzunit.sh > M build-tools/runlztest.sh > A build-tools/prepare-lzo-test.sh > M lps/components/lzunit/lzunit.lzx > M lps/components/lztest/lztestmanager.lzx > > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20091211-hqm-e.tar -- Regards, Max Carlson OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
