Did you verify that the LPP-7940 test case still passes? Otherwise approved.
On 2009-12-17, at 00:27, Max Carlson wrote: > Change 20091216-maxcarlson-O by maxcarl...@bank on 2009-12-16 18:42:46 PST > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: UPDATED: Update embedding scripts to avoid document.write() > > Bugs Fixed: LPP-7940 -Make dhtml embedding use DOM operations instead of > document.write > > Technical Reviewer: hminsky > QA Reviewer: ptw > > Details: LzSprite - Add write_css_with_createstylesheet quirk, set to true in > IE. Update writeCSS() to handle special case for dynamically created > stylesheets in IE and other browsers. > > embednew - Use __dhtmlLoadLibrary() to embed apps, update _getAppendDiv() to > use DOM APIs to create new embed divs when missing. > > dev-console - Update to include new LFC. > > Tests: All apps run as before in IE, Safari and Firefox DHTML. > > Files: > M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js > M lps/includes/source/embednew.js > M lps/admin/dev-console.lzx.js > M lps/admin/dev-console.sprite.png > M lps/admin/dev-console.lzx.swf > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20091216-maxcarlson-O.tar > > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
