I agree we should do this, but I'm concerned about changing a
customer-facing API so late in the release cycle. I'm sure this will
affect anyone with a custom wrapper, including webtop!
How about I prepend 'lz' to the query names to reduce the chance of
namespace issues? Then it's less likely to collide with an existing
query arg...
In the documentation I imply the extra query args are for
testing/temporary purposes only, and I say 'Please adjust your wrapper
HTML to reflect these settings in <code>lz.embed.<xsl:value-of
select="$methodname"/>({...})</code> when you get them the way you'd
like.' - see deployment-response.xslt...
On 12/18/09 5:15 AM, P T Withington wrote:
> I'm concerned about query arg space pollution. If we are expanding the query
> args intercepted by the server to all the embed properties, we really need to
> implement:
>
> http://jira.openlaszlo.org/jira/browse/LPP-3479
>
> so we don't collide with application query args. Don't you agree?
>
> On 2009-12-17, at 18:28, Max Carlson wrote:
>
>> Change 20091217-maxcarlson-C by maxcarl...@bank on 2009-12-17 14:33:20 PST
>> in /Users/maxcarlson/openlaszlo/trunk-clean
>> for http://svn.openlaszlo.org/openlaszlo/trunk
>>
>> Summary: Allow lz.embed.swf/dhtml() properties to be overridden with qury
>> string values, add master sprite checkbox to the dev console.
>>
>> Bugs Fixed: LPP-8622 - DHTML: Combine all css sprites into a single large
>> image
>>
>> Technical Reviewer: ptw
>> QA Reviewer: hminsky
>>
>> Release Notes: lz.embed.swf/dhtml() properties can now be overridden by
>> adding
>> them to the query string when the app is loaded. For example, to test the
>> calendar demo with 'usemastersprite' set to true, change
>> 'demos/calendar/calendar.lzx?lzr=dhtml' to
>> 'demos/calendar/calendar.lzx?lzr=dhtml&usemastersprite=true'. See the
>> 'Server' deploy button in the developer console for more details on what
>> options are available for your runtime.
>>
>> Details: embed-body.xslt - Default usemastersprite to false, add explicit
>> setting for approot.
>>
>> deployment-response - Improve documentation to reflect the new query string
>> feature and be generally more clear.
>>
>> embednew - Explicitly process application query string args into options
>> that can be used to override properties on a per-request basis. Correct
>> braino in approot processing.
>>
>> dev-console - Add checkbox for 'Use master sprite' to the dev console in
>> DHTML, and set in the query string a la debug, lzr and lzbacktrace.
>> Recompile to take advantage of the new setting.
>>
>> Tests: Firebug shows fewer requests when the 'Use master sprite' option is
>> checked in the DHTML developer's console.
>>
>> Files:
>> M WEB-INF/lps/templates/embed-body.xslt
>> M WEB-INF/lps/templates/deployment-response.xslt
>> M lps/includes/source/embednew.js
>> M lps/admin/dev-console.lzx.js
>> M lps/admin/dev-console.sprite.png
>> M lps/admin/dev-console.lzx.swf
>> M lps/admin/dev-console.lzx
>>
>> Changeset:
>> http://svn.openlaszlo.org/openlaszlo/patches/20091217-maxcarlson-C.tar
>>
>> _______________________________________________
>> Laszlo-reviews mailing list
>> [email protected]
>> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
>
--
Regards,
Max Carlson
OpenLaszlo.org
_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
