Approved!

On 2010-01-07, at 09:40, Henry Minsky wrote:

> Change 20100107-hqm-C by [email protected] on 2010-01-07 08:07:32 EST
>    in /Users/hqm/openlaszlo/trunk
>    for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: remove pointers to AST and DOM before calling flex compiler
> 
> New Features:
> 
> Bugs Fixed:
> 
> Technical Reviewer: ptw
> QA Reviewer: max
> Doc Reviewer: (pending)
> 
> Documentation:
> 
> Release Notes:
> 
> Overview:
> 
> 
> By nulling out pointers to the AST and DOM before calling the flex compiler 
> this appears to save a noticable amount of RAM,
> based on inspecting a heap dump.
> 
> 
> Details:
> 
> compiler.Compiler: null out pointer to DOM before calling backend compiler
> 
> sc.Compiler:  null out pointers to AST before calling back-end compiler
> 
> SWF9Generator: remove pointers to the AST before calling flex compiler
> 
> TranslationUnit: don't null out the lnums table, turns out we need to keep it
> until the flex compilation is done,  to report original line numbers in case 
> of a compilation error.
> 
> 
> Tests:
> 
> ant runlzunit
> amazon
> calendar
> IBM app compiles with debug+backtrace in swf9 debug, takes 5 min on 2GB XP 
> machine (1 min improvement)
> test/compiler_errors/attribute-overrides-method.lzx 
> 
> 
> Files:
> M       WEB-INF/lps/server/src/org/openlaszlo/sc/SWF9Generator.java
> M       WEB-INF/lps/server/src/org/openlaszlo/sc/Compiler.java
> M       WEB-INF/lps/server/src/org/openlaszlo/compiler/Compiler.java
> M       WEB-INF/lps/server/src/org/openlaszlo/sc/TranslationUnit.java
> 
> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100107-hqm-C.tar
> 
> _______________________________________________
> Laszlo-reviews mailing list
> [email protected]
> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews


_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews

Reply via email to