It's __LZdelayedSetters that you are eliminating, not __LZresolveReferences, right?
How about we change `-1` to `null`, then I will be happy. (I believe Adam had to use `-1` in swf5 because in swf5 `null instanceof Function` returned true! I don't really like the modularity of LzNode/__LZresolveReferences looking for LzView/$lzc$set_layout. Either layout should be hoisted up to node, or view should override resolveReferences to do its layout processing, right? On 2010-01-13, at 16:46, Max Carlson wrote: > Change 20100113-maxcarlson-h by maxcarl...@bank on 2010-01-13 11:05:24 PST > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: UPDATED: Optimize LzNode > > Bugs Fixed: LPP-8716 - Improved LzNode startup time > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Details: Per Andre's comments, eliminate all references to > __LZresolveReferences. Still waiting for Tucker to chime in about '!= -1' vs > 'is Function'. > > LzNode - Check for presence of __LZresolveDict before installing computed > initializations (could save a function call). Explicitly test for read-only > setters in __LZapplyArgs() (testing '!= -1' should be faster than 'is > Function'). In __LZresolveReferences(), install layouts explicitly and > comment out generalized loop, formerly used for backward compatibility > (should be much faster). > > Tests: All apps run as before, including smoketest. > > Files: > M WEB-INF/lps/lfc/core/LzNode.lzs > M WEB-INF/lps/lfc/views/LaszloView.lzs > M WEB-INF/lps/lfc/views/LaszloCanvas.lzs > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100113-maxcarlson-h.tar > > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
