Yeah we should really do that. I need to modify the compiler and the library loader to append the runtime to the filename. I'll file an improvement for that.
On Sat, Jan 23, 2010 at 7:41 PM, Max Carlson <[email protected]> wrote: > Yeah, I'll bet that's the issue. After a clean build, I could get swf10 to > work just fine. After running under swf8/10, the same test failed. > > If the library is runtime-specific, shouldn't the runtime be included in > the URL somehow and selected that way? > > > On 1/23/10 1:30 PM, Henry Minsky wrote: > >> Can you try running with my original patch, but clear the browser cache >> (and maybe the server cache) when you switch runtimes? >> >> >> >> On Fri, Jan 22, 2010 at 10:25 PM, Henry Minsky <[email protected] >> <mailto:[email protected]>> wrote: >> >> I think that was an error due to loading a swf8 library into swf10 >> app somehow. >> >> The library file gets written out in the build/appname subdirectory, >> without a runtime >> in the filename, so it just looks like >> >> class-and-view-library.lzx.swf >> >> Maybe the browser cached the swf8 version.. >> >> >> On Fri, Jan 22, 2010 at 4:46 PM, Max Carlson <[email protected] >> <mailto:[email protected]>> wrote: >> >> Not approved. The first time I ran >> >> http://localhost:8080/trunk-clean/test/snippets/import-class-and-view.lzx?lzr=swf10 >> it worked. Now I'm getting this: >> >> ReferenceError: Error #1069: Property exportClassDefs not found >> on flash.display.AVM1Movie and there is no default value. >> at LzLibrary/handleLoadComplete() >> >> >> >> On 1/22/10 11:00 AM, Henry Minsky wrote: >> >> Change 20100122-hqm-F by [email protected] on 2010-01-22 >> 13:41:34 EST >> in /Users/hqm/openlaszlo/trunk >> for http://svn.openlaszlo.org/openlaszlo/trunk >> >> Summary: fix for bug in swf10 (and other runtimes) snippets >> >> New Features: >> >> Bugs Fixed: LPP-8727 bug in dynamic libraries >> >> Technical Reviewer: ptw >> QA Reviewer: max >> Doc Reviewer: (pending) >> >> Documentation: >> >> Release Notes: >> >> Overview: >> >> When the compiler compiles an<import> library, it makes a new >> compilation environment for emitting the code. However the >> ClassModels >> that it looks up may have the compilation environment of the >> main app, as they >> may have been created during the updateSchema phase. >> >> >> Details: >> >> ClassCompiler: The change is to set the classmodel's >> CompilationEnvironment to the >> current Compiler's value, so that any anon classes that get >> made will >> inherit that value. >> >> NodeModel: ensure that class is always emitted (this wasn't >> the bug in this case, >> but seemed like an oversight) >> >> ClassModel: make env var public, so it can be set by the >> ClassCompiler >> >> Tests: >> >> run in swf8,10,dhtml >> >> test/snippets/import-class-and-view.lzx >> test/snippets/lpp-8727.lzx >> test/snippets/import-view.lzx >> test/snippets/import-class-and-view.lzx >> test/snippets/import-class-and-view-direct.lzx >> test/snippets/import-class-resource.lzx >> test/snippets/import-dataload.lzx?lzr=swf10 >> >> >> ant runlzunit >> >> >> >> Files: >> M >> >> WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassCompiler.java >> M >> WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java >> M >> WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java >> A test/snippets/class-and-view-library-noproxied.lzx >> M test/snippets/import-class-and-view-direct.lzx >> M test/snippets/class-and-view-library.lzx >> A test/snippets/lpp-8727-library.lzx >> M test/snippets/class-and-view-library-proxied.lzx >> A test/snippets/lpp-8727.lzx >> M test/snippets/import-class-resource.lzx >> >> Changeset: >> >> http://svn.openlaszlo.org/openlaszlo/patches/20100122-hqm-F.tar >> >> >> -- >> Regards, >> Max Carlson >> OpenLaszlo.org >> >> >> >> >> -- >> Henry Minsky >> Software Architect >> [email protected] <mailto:[email protected]> >> >> >> >> >> >> -- >> Henry Minsky >> Software Architect >> [email protected] <mailto:[email protected]> >> >> >> > -- > Regards, > Max Carlson > OpenLaszlo.org > -- Henry Minsky Software Architect [email protected]
_______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
