On 2010-01-26, at 15:35, Henry Minsky wrote: > On Tue, Jan 26, 2010 at 3:24 PM, P T Withington <[email protected]>wrote: > >> Not approved yet: >> >> 1) I don't buy the copying of the tooltip code into the debug window. a) >> If you don't rename it, it's going to collide with any app that includes the >> component tooltip; b) doesn't the debugger already use other components? If >> you really want to insulate the debug window from the app, it needs to be >> solo compiled and run in a separate (floating?) iframe, like the console. >> > > Hmm, yeah I guess you're right. I'd rather rename the class, or else we > should move the class to components/lz, because I don't want to be loading > class files from the incubator directory.
I'd say move it to lz then. tooltips have been around for a while and I gave this implementation a pretty thorough work-over to make it reasonably efficient not long ago. >> 2) You and Max need to resolve how the multi-frame resources are really >> supposed to work, which should be a separate bug, not papered-over with this >> change. >> > > Yeah, I need to discuss that with Max. I'm trying to decide whether the > compiler should try to > identify which runtime the swf asset is compiled for, and only use it if it > matches > exactly the target runtime. > > Otherwise, the compiler should fallback to look the autoPng > directory. If there's no autoPng, then I guess we could embed the swf and > hope for the best, or print a warning, or throw an error... > > A single static swf8 will display in a swf9 or swf10 app, but there's no > control over the playback so you can't choose a frame of a multiframe > movieclip. > > A swf10 asset won't work at all in a swf8 app, I don't think. > >> 3) I guess I approve adding the bugReport button for show, but we really >> need a better way, because you have to first select the error you want to >> report before you can really just push the button... >> > > Should the debugger keep a pointer to the most recent error it's displayed, > and then the bug report would refer to the last one by default? That seems like a reasonable idea. If we do that, I'd go along with adding the button. I could make that change separately, I'll send it to you to review. >> I think we are rushing this out to get a "screen shot" for OL <view> and we >> should instead make a more vanilla shot of using bugReport from the command >> line and think this whole idea through more carefully. >> >> On 2010-01-25, at 11:28, Henry Minsky wrote: >> >>> Change 20100125-hqm-E by [email protected] on 2010-01-25 11:24:21 EST >>> in /Users/hqm/openlaszlo/trunk6 >>> for http://svn.openlaszlo.org/openlaszlo/trunk >>> >>> Summary: update some buttons in the debug window >>> >>> New Features: >>> >>> Bugs Fixed: >>> >>> Technical Reviewer: ptw >>> QA Reviewer: max >>> Doc Reviewer: (pending) >>> >>> Documentation: >>> >>> Release Notes: >>> >>> Overview: >>> >>> + Added a bug-report button to main debugger window >>> + Added tooltips >>> + Updated button resources to use pngs so they animate properly in swf10 >> runtime >>> >>> >>> Details: >>> >>> + debugger.lzx: explicitly declare multiframe resources for buttons, so >> the flash10 compiler can >>> compile multiframe resources from .png files >>> >>> + added tooltips, but made a copy of tooltip code from incubator, to keep >> debugger somewhat >>> self contained. >>> >>> >>> >>> Tests: >>> >>> + mouse over buttons in debugger, see tooltips >>> >>> + in swf10, mouse over / click on buttons in debugger shows proper >> resource frames >>> >>> Files: >>> M lps/components/debugger/debugger.lzx >>> M lps/components/debugger/newcontent.lzx >>> A lps/components/debugger/tooltipview.lzx >>> A lps/components/debugger/images/tooltip_pointer_up.png >>> A lps/components/debugger/images/tooltip_pointer_dn.png >>> A lps/components/debugger/images/buttons/autoPng/bug0001.png >>> A lps/components/debugger/images/buttons/autoPng/bug0002.png >>> A lps/components/debugger/images/buttons/autoPng/bug0003.png >>> A lps/components/debugger/tooltip.lzx >>> >>> Changeset: >> http://svn.openlaszlo.org/openlaszlo/patches/20100125-hqm-E.tar >>> >>> _______________________________________________ >>> Laszlo-reviews mailing list >>> [email protected] >>> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews >> >> > > > -- > Henry Minsky > Software Architect > [email protected] > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
