It's only intended as a default, for the naive user, who would presumably be 
reporting the (only) error they get.  In particular, I don't want it to default 
to reporting a warning that may have come after an error.

You explicitly pass any message as the argument to bugReport by inspecting it, 
which will make that message be the value of `_`, which will be preferred as 
the argument if it is a debug message (of any type).

On 2010-01-26, at 18:17, Max Carlson wrote:

> Not approved.  This change doesn't work with anything but Debug.error() - it 
> should support write(), debug() and info() also...
> 
> On 1/26/10 1:28 PM, P T Withington wrote:
>> Change 20100126-ptw-S by [email protected] on 2010-01-26 16:26:17 EST
>>     in /Users/ptw/OpenLaszlo/trunk/WEB-INF/lps/lfc/debugger
>>     for http://svn.openlaszlo.org/openlaszlo/trunk/WEB-INF/lps/lfc/debugger
>> 
>> Summary: Make Debug.bugReport default to the last error reported
>> 
>> Bugs Fixed: LPP-5063 Add bug report button to the debugger UI (partial)
>> 
>> Technical Reviewer: hminsky (pending)
>> QA Reviewer: max (pending)
>> 
>> Details:
>>     LzMessage: record the last LzError
>> 
>>     LzDebug: use that as the default to report if there is no more
>>     specific argument to Debug.bugReport.
>> 
>> Tests:
>>     Inspection.
>> 
>> Files:
>> M      LzMessage.lzs
>> M      LzDebug.lzs
>> 
>> Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100126-ptw-S.tar
> 
> -- 
> Regards,
> Max Carlson
> OpenLaszlo.org


_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews

Reply via email to