On Wed, Jan 27, 2010 at 11:55 AM, P T Withington <[email protected]>wrote:
> Approved with comments: > > I'm trying to decide if the bug report button should pass `lastError` > explicitly, or just rely on the default, which is to use the value of `_` if > it is a debugger message and failing that fall back to `lastError`. Your > choice. > > The patch makes it look like you copied the tooltip resources to the > debugger rather than moving them into lz? Maybe you just forgot to revert > those copies? > oops yes forgot to revert those > > Did you use `svn mv` to move the tooltip code? `mv` is preferred over > delete and add because it will preserve the change history. If you did not > use `svn mv` you should revert and do that. > Yes I did an svn mv of the whole tooltip directory. > > On 2010-01-27, at 10:15, Henry Minsky wrote: > > > uses new Debug. lastError property > > > > Change 20100125-hqm-E by [email protected] on 2010-01-25 11:24:21 EST > > in /Users/hqm/openlaszlo/trunk6 > > for http://svn.openlaszlo.org/openlaszlo/trunk > > > > Summary: update some buttons in the debug window > > > > New Features: > > > > Bugs Fixed: > > > > Technical Reviewer: ptw > > QA Reviewer: max > > Doc Reviewer: (pending) > > > > Documentation: > > > > Release Notes: > > > > Overview: > > > > + Added a bug-report button to main debugger window > > + Moved tooltips to lz/components > > + Updated button resources to use pngs so they animate properly in swf10 > runtime > > > > > > Details: > > > > + debugger.lzx: explicitly declare multiframe resources for buttons, so > the flash10 compiler can > > compile multiframe resources from .png files > > > > + moved tooltips from incubator to lz/tooltip directory > > > > > > Tests: > > > > + mouse over buttons in debugger, see tooltips > > > > + in swf10, mouse over / click on buttons in debugger shows proper > resource frames > > > > Files: > > M lps/components/debugger/debugger.lzx > > M lps/components/debugger/newcontent.lzx > > A lps/components/debugger/images/tooltip_pointer_up.png > > A lps/components/debugger/images/tooltip_pointer_dn.png > > A lps/components/debugger/images/buttons/autoPng/bug0001.png > > A lps/components/debugger/images/buttons/autoPng/bug0002.png > > A lps/components/debugger/images/buttons/autoPng/bug0003.png > > A lps/components/lz/tooltip > > D lps/components/incubator/tooltip/tooltipview.lzx > > D lps/components/incubator/tooltip/tooltip.lzx > > D lps/components/incubator/tooltip/resources/tooltip_pointer_up.png > > D lps/components/incubator/tooltip/resources/tooltip_pointer_dn.png > > D lps/components/incubator/tooltip/resources > > D lps/components/incubator/tooltip > > > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100125-hqm-E.tar > > > > _______________________________________________ > > Laszlo-reviews mailing list > > [email protected] > > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews > > -- Henry Minsky Software Architect [email protected]
_______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
