Seems reasonable to me. Approved! ---
For future thought: Do we want a general utility in embed.js that grabs _all_ keystrokes from the browser? Or at least keystrokes the application attaches a handler to (via the command-keys thingy)? On 2010-01-28, at 15:19, Max Carlson wrote: > Change 20100128-maxcarlson-I by maxcarl...@bank on 2010-01-28 12:11:40 PST > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Prevent browser tab key from escaping swf9/10 movies in IE > > Bugs Fixed: LPP-8713 - OL 4.7.X -SWF10 - IE7 - Small Applications - Animation > - Can not tab between the different buttons at the top of the app > > Technical Reviewer: ptw > QA Reviewer: hminsky > > Details: LzKeyboardKernel - Receive browser tab events and generate > artificial tab key events. __keyboardEvent() now expects any object (not > just KeyboardEvents) so artifical objects can be injected. > > LzKeys - Forward tab events to LzKeyboardKernel. > > embednew - Listen for and cancel bubbling for browser tab key events for IE 7 > Flash, when the version is > swf8 and the cancelkeyboardcontrol option != > true. > > Tests: See LPP-8713 > > Files: > M WEB-INF/lps/lfc/kernel/swf9/LzKeyboardKernel.as > M WEB-INF/lps/lfc/services/LzKeys.lzs > M lps/includes/source/embednew.js > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100128-maxcarlson-I.tar > > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
