I'll review the details in a bit, but I'd like to see another test case with
embedded newlines and multiline text:
<canvas>
<vbox>
<text id="cond" bgcolor="#ffaaaa" text=" Hello \n Laszlo! "
multiline="true" condensewhite="true"/>
<text id="nocond" bgcolor="#ffaaaa" text=" Hello \n Laszlo! "
multiline="true" condensewhite="false"/>
</vbox>
</canvas>
Do we need to worry about inputtext too?
On 2010-01-29, at 17:55, Max Carlson wrote:
> Change 20100129-maxcarlson-W by maxcarl...@bank on 2010-01-29 14:41:50 PST
> in /Users/maxcarlson/openlaszlo/trunk-clean
> for http://svn.openlaszlo.org/openlaszlo/trunk
>
> Summary: Add condensewhite attribute for consensing whitespace in text
>
> Bugs Fixed: LPP-7558 - DHTML <text> does not preserve whitespace
>
> Technical Reviewer: ptw
> QA Reviewer: hminsky
>
> Details: */LzTextSprite.as - Add condenseWhiteSpace() implementation, modify
> setText() to collapse whitespace when condensewhite == true;
>
> Library.lzs - Move RegExp declaration before LzTextSprite so it can be used
> by text sprites.
>
> LzSprite.js - When inner_html_no_entity_apos quirk is true compile
> inner_html_no_entity_apos_re once, like for the inner_html_strips_newlines
> quirk.
>
> LzTextSprite.js - If condensewhite == true, remove nonbreaking spaces -
> otherwise, replace spaces with nonbreaking spaces. Add condenseWhiteSpace()
> implementation.
>
> LzText.lzs - Add condensewhite attribute, event and setter.
>
> Tests: The following shows collapsed whitespace where condensewhite is true:
> <canvas>
> <vbox>
> <text id="cond" bgcolor="#ffaaaa" text=" Hello Laszlo! "
> condensewhite="true"/>
> <text id="nocond" bgcolor="#ffaaaa" text=" Hello Laszlo! "
> condensewhite="false"/>
> </vbox>
> </canvas>
>
>
> Files:
> M WEB-INF/lps/lfc/kernel/swf/LzTextSprite.as
> M WEB-INF/lps/lfc/kernel/swf/Library.lzs
> M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js
> M WEB-INF/lps/lfc/kernel/dhtml/LzTextSprite.js
> M WEB-INF/lps/lfc/kernel/swf9/LzTextSprite.as
> M WEB-INF/lps/lfc/views/LzText.lzs
>
> Changeset:
> http://svn.openlaszlo.org/openlaszlo/patches/20100129-maxcarlson-W.tar
>
> _______________________________________________
> Laszlo-reviews mailing list
> [email protected]
> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
