On 2/5/10 7:17 AM, P T Withington wrote: > Couple of questions: > > 1. Should there be a general property `border` as there is for `shadow`, > since you could have a border with width but style none, which would still > effectively be 'blank'? And you would use this rather than just border-width > for testing blankness (and setting and caching the border settings).
I don't think so, because we don't allow folks to change the border style. > 2. What are the new `radius1=null, radius2=null, radius3=null` parameters on > setCornerRadius. They seem to be unused. Ignore those - they shouldn't be part of this change. I started work on allowing the 4 corner radii to be set independently, but that will be part of another change. > On 2010-02-04, at 20:20, Max Carlson wrote: > >> Change 20100204-maxcarlson-a by maxcarl...@bank on 2010-02-04 17:13:51 PST >> in /Users/maxcarlson/openlaszlo/trunk-clean >> for http://svn.openlaszlo.org/openlaszlo/trunk >> >> Summary: Fix cornerradius, borderwidth and bordercolor behavior in DHTML >> >> Bugs Fixed: LPP-8742 - Cornerradius, borderwidth and bordercolor unreliable >> in DHTML >> >> Technical Reviewer: ptw >> QA Reviewer: hminsky >> >> Details: Dhtml sprites with a borderwidth should use their true height, >> canceling quirks.size_blank_to_zero as needed. Add explicit entry for >> shadow property, and use to prevent sprurious updates. Apply cornerradius >> to click and context menu divs. Add explicit setter for borderColor. >> Click/contextmenu sprites use transparent borders to ensure they're the >> correct size but don't produce artifacts when their sprite is covered, e.g. >> with the debugger. >> >> Tests: See LPP-8742 >> >> Files: >> M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js >> >> Changeset: >> http://svn.openlaszlo.org/openlaszlo/patches/20100204-maxcarlson-a.tar >> >> _______________________________________________ >> Laszlo-reviews mailing list >> [email protected] >> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews > _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
