Approved! On 2/9/10 12:23 PM, P T Withington wrote: > [Would like to get this into 4.7.1 because I think it is the only thing > blocking swf9 .lzo's] > > Change 20100209-ptw-6 by [email protected] on 2010-02-09 15:06:31 EST > in /Users/ptw/OpenLaszlo/trunk > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Make tag compiler runtime neutral > > Bugs Fixed: LPP-8604 runtime-specific code being inserted by ClassModel in > the tag compiler > > Technical Reviewer: hminsky (pending) > QA Reviewer: max (pending) > > Details: > NodeModel: Don't put file/line on nodes classes. It's > non-portable, and we have a better mechanism (backtrace > annotations). There is no reason to disallow<passthrough> in the > tag compiler, let the back end worry about that. > > ClassModel: Be honest and declare a valid default constructor for > all tag classes (instead of relying on undocumented behavior of > our class runtime). > > build.xml: type-oh noticed in passing > > Tests: > smokecheck and test case from forums works in all runtimes. > > Files: > M WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java > M WEB-INF/lps/server/src/org/openlaszlo/compiler/ClassModel.java > M build.xml > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100209-ptw-6.tar
-- Regards, Max Carlson OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
