Not approved. - dhtml: -> remove "globalAlpha" handling from "__updateStyles()"
swf: - can't use beginPath() etc, fillRect() must not affect the current path [1] - swf8: createContainer() -> context menu handling broken -> why calling getNextHighestDepth()? -> why assigning "this.context"? - swf9/10: createContainer() -> "mouseEnabled" is set to false for __drawcontainer, but not for the drawing context, maybe you want to use "DisplayObjectContainer#mouseChildren" instead? rebuildBitmap() -> "if (! dc) return;" - why? existence already checked right at the beginning of the function [1] http://www.whatwg.org/specs/web-apps/current-work/#simple-shapes-%28rectangles%29 On 2/22/2010 11:02 PM, Max Carlson wrote: > Change 20100222-maxcarlson-q by maxcarl...@bank on 2010-02-22 13:45:49 PST > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Fix drawview.fillRect() in dhtml/swf8/10 > > Bugs Fixed: LPP-8778 - Drawview.fillRect() doesn't work properly in swf or > dhtml when alpha is applied > > Technical Reviewer: ptw > QA Reviewer: [email protected] > > Details: Remove unused __rrfactors attribute. DHTML's __updateFillStyle() > now respects globalAlpha. swf8/10 use restructured sprite/movieclip > heirarchy - now everything drawview-related goes inside a single > __drawcontainer, with the __bitmapcontainer always resting behind any drawing > context(s). createContainer() calls __rebuildBitmap() directly, to ensure > it's placed behind any drawing contexts. fillRect() used vector graphics > when alpha != 1 to avoid issue where pixel values are replaced instead of > drawn on top of. > > Tests: Updated testcase from LPP-8778 looks consistend in dhtml, swf8 and > swf10. > > Files: > M lps/components/extensions/drawview.lzx > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100222-maxcarlson-q.tar > _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
