Approved! On 2/24/10 12:46 PM, P T Withington wrote: > Change 20100224-ptw-W by [email protected] on 2010-02-24 15:30:00 EST > in /Users/ptw/OpenLaszlo/trunk > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Don't warn for missing attribute style when there is a default value > > Bugs Fixed: LPP-8772 Provide way to avoid 'No applicable value for CSS > property %w and there is no default.' warnings in LZX attributes > > Technical Reviewer: max (pending) > QA Reviewer: hminsky (pending) > > Release Notes: > > When you assign a CSS style property to an attribute using: > > <attribute ... style="property" ... > > you will get a warning at runtime in debug mode if there is no > applicable CSS > value for that property. You can silence these warnings by giving > a default value for your attribute: > > <attribute ... style="property" value="default" ... > > When there is no applicable CSS value, the default value will be > used for the attribute instead, and there will be no warning. > > Details: > > NodeModel: When there is a fallback (default) value, also pass > `false` as the `warn` parameter to silence any warning. > > Tests: > Test case from bug report. NOTE: The test case still gives a > warning that "void 0" is an invalid color string, but that is a > separate problem. > > Files: > M WEB-INF/lps/server/src/org/openlaszlo/compiler/NodeModel.java > > Changeset: http://svn.openlaszlo.org/openlaszlo/patches/20100224-ptw-W.tar
-- Regards, Max Carlson OpenLaszlo.org _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
