I'm not following your logic on not tracking delegates.  The event system 
tracks events, and will unregister delegates that are listening to events when 
a node is destroyed, but we don't (yet) have a corresponding mechanism for 
delegates (that I can see).

releaseLayout seems to be a public API, so you can't just remove it without an 
RFC.  I agree that it seems like a useless API if there is not a corresponding 
applyLayout, and if there were that pair, I would say they should be reduced to 
a single property `applied` that did the right thing.

The rest of the optimizations are approved.

On 2010-03-10, at 12:59, Max Carlson wrote:

> Change 20100310-maxcarlson-u by maxcarl...@bank on 2010-03-10 09:34:20 PST
>    in /Users/maxcarlson/openlaszlo/trunk-clean
>    for http://svn.openlaszlo.org/openlaszlo/trunk
> 
> Summary: Optimize LaszloLayout
> 
> Bugs Fixed: LPP-8822 - Improve layout performance
> 
> Technical Reviewer: ptw
> QA Reviewer: hminsky
> 
> Details: Remove delegate tracking, now handled by the event system.  Add 
> types for AS3.  Move contents of releaseLayout() to destroy() - a separate 
> method shouldn't be needed.  Use options hash directly, shorten this.subviews 
> lookups.
> 
> Tests: Lzpix, calendar run as before.
> 
> Files:
> M       WEB-INF/lps/lfc/controllers/LaszloLayout.lzs
> M       lps/components/utils/layouts/resizelayout.lzx
> 
> Changeset: 
> http://svn.openlaszlo.org/openlaszlo/patches/20100310-maxcarlson-u.tar
> 
> _______________________________________________
> Laszlo-reviews mailing list
> [email protected]
> http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews


_______________________________________________
Laszlo-reviews mailing list
[email protected]
http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews

Reply via email to