By the rules that I understand for the javascript property names corresponding to CSS styles, shouldn't the webkit properties be `Webkit*` (as they are `-webkit*` in CSS.
Why is it we need to set border radius on canvas and img, but not border width? Or conversely, why is it that we _do_ have to set border width on context and click? A comment or two would go a long way... Does the drawing test test corner radius on all these cases? views with/without click, context, canvas, img? Meta question: It seems a sprite can now have a div, a click div, a context div, a canvas div, and an img div. So, 5 HTML objects to represent 1 view? Aren't these getting a little heavy? Maybe we should break out some of the more esoteric sprite stuff into subclasses? On 2010-03-12, at 14:29, Max Carlson wrote: > Change 20100312-maxcarlson-o by maxcarl...@bank on 2010-03-12 11:18:39 PST > in /Users/maxcarlson/openlaszlo/trunk-clean > for http://svn.openlaszlo.org/openlaszlo/trunk > > Summary: Apply cornerradius to img and canvas elements > > Bugs Fixed: LPP-8745 - Add support for border-radius to view (partial) > > Technical Reviewer: hminsky > QA Reviewer: ptw > > Details: Set default border properties in CSS prototype, remove unneeded test > in setSource(), insert canvas divs behind any others, don't set shadows when > shadowdistance == 0 && shadowblurradius == 0, correct bordercolor setting for > null values, set corner radius for image and canvas elements. > > Tests: test/drawing/drawing.lzx runs as before in DHTML. > > Files: > M WEB-INF/lps/lfc/kernel/dhtml/LzSprite.js > > Changeset: > http://svn.openlaszlo.org/openlaszlo/patches/20100312-maxcarlson-o.tar > > _______________________________________________ > Laszlo-reviews mailing list > [email protected] > http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews _______________________________________________ Laszlo-reviews mailing list [email protected] http://www.openlaszlo.org/mailman/listinfo/laszlo-reviews
